Issue 101223003: SyncFS: Handle HTTP_CONFLICT as Precondition error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101223003: SyncFS: Handle HTTP_CONFLICT as Precondition error (Closed)

Created:
7 years ago by kinuko

Modified:
7 years ago

Reviewers:
nhiroki, tzik

CC:
chromium-reviews, kinuko+watch, nhiroki, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

SyncFS: Handle HTTP_CONFLICT as Precondition error DriveService seems to return HTTP_CONFLICT when precondition error is returned from Drive. (At least for Upload) BUG=none TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238393

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinuko

There're some more issues around update/delete case, but anyway this fixes some issues. PTL

7 years ago (2013-12-03 11:58:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/101223003/1

7 years ago (2013-12-03 12:47:46 UTC) #3

Message was sent while issue was closed.

Change committed as 238393

Expand Messages | Collapse Messages