Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1012173002: Install warning message for extensions that use chrome.mdns API. (Closed)

Created:
5 years, 9 months ago by Red Daly
Modified:
5 years, 9 months ago
Reviewers:
mark a. foltz
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Install warning message for extensions that use chrome.mdns API. BUG=451526 Committed: https://crrev.com/771d3a91dee58af8bf7bd0f3d3fc909c44ddeb51 Cr-Commit-Position: refs/heads/master@{#321500}

Patch Set 1 #

Patch Set 2 : Remove install message code but leave .grd for new string #

Patch Set 3 : Code for "mdns" permission installation warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/permission_warnings.html View 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_rules.cc View 2 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/permissions/permission_message.h View 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Red Daly
5 years, 9 months ago (2015-03-18 23:04:26 UTC) #2
mark a. foltz
lgtm but you will need an OWNER for extensions
5 years, 9 months ago (2015-03-19 00:00:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012173002/20001
5 years, 9 months ago (2015-03-20 01:33:31 UTC) #6
Red Daly
On 2015/03/20 01:33:31, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 9 months ago (2015-03-20 01:35:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 02:28:44 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 02:30:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/771d3a91dee58af8bf7bd0f3d3fc909c44ddeb51
Cr-Commit-Position: refs/heads/master@{#321500}

Powered by Google App Engine
This is Rietveld 408576698