Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1012163002: content: Cancel all DeletedDiscardableSharedMemory callbacks in dtor. (Closed)

Created:
5 years, 9 months ago by reveman
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Cancel all DeletedDiscardableSharedMemory callbacks in dtor. Avoid IPC from ChildDiscardableSharedMemoryManager dtor in case the channel has been closed at destruction time. BUG=467958 TEST=content_browsertests --gtest_filter=ChildDiscardableSharedMemoryManagerBrowserTest.* Committed: https://crrev.com/3d246168a99a21215f4868de7c01b9236e28b91a Cr-Commit-Position: refs/heads/master@{#320965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M content/child/child_discardable_shared_memory_manager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/child/child_discardable_shared_memory_manager.cc View 3 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
5 years, 9 months ago (2015-03-17 18:15:21 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 9 months ago (2015-03-17 19:58:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012163002/1
5 years, 9 months ago (2015-03-17 19:59:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 20:46:06 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 20:46:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d246168a99a21215f4868de7c01b9236e28b91a
Cr-Commit-Position: refs/heads/master@{#320965}

Powered by Google App Engine
This is Rietveld 408576698