Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1012153002: [indexeddb] Fix IndexedDBBrowserTest.ConnectionsClosedOnTabClose to retain the db. (Closed)

Created:
5 years, 9 months ago by rmcilroy
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[indexeddb] Fix IndexedDBBrowserTest.ConnectionsClosedOnTabClose to retain the db. Fix IndexedDBBrowserTest.ConnectionsClosedOnTabClose to ensure that the first tab holds a reference to the DB after it does setVersion to ensure that if a GC happens before the second tab is loaded, the second tab still get's blocked from doing it's version update. Previously if a GC happened at this time then the test would hang as the second tab would set it's title immediately to "setVersion(3) complete" bypassing the "setVersion(3) blocked" title. This was failing when long idle times were enabled because the long idle times caused more GC when the tab went idle. BUG=467655 Committed: https://crrev.com/1edacadd43ecfb53d12918dc18854af856c7ad8f Cr-Commit-Position: refs/heads/master@{#320957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/test/data/indexeddb/version_change_blocked.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rmcilroy
PTAL, thanks.
5 years, 9 months ago (2015-03-17 18:08:27 UTC) #2
jsbell
lgtm - thanks for finding/fixing!
5 years, 9 months ago (2015-03-17 18:19:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012153002/1
5 years, 9 months ago (2015-03-17 18:22:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 19:27:39 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 19:28:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1edacadd43ecfb53d12918dc18854af856c7ad8f
Cr-Commit-Position: refs/heads/master@{#320957}

Powered by Google App Engine
This is Rietveld 408576698