Simple patch to have draw path call an internal drawPath

Simple patch to have draw path call an internal drawPath

The purpose of this patch is to expose an internal draw path call which text contexts can use.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5efb8b8407c956b7fbb85236f3f538f2a104fe98

[joshualitt, 2015-03-18 17:39:45]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com, jvanverth@google.com, robertphillips@google.com

[jvanverth1, 2015-03-18 17:44:17]

Seems reasonable, just one comment.

https://codereview.chromium.org/1012143005/diff/1/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/1012143005/diff/1/src/gpu/SkGpuDevice.h#newco...
src/gpu/SkGpuDevice.h:126: // This call is *ONLY* for SkGpuDevice itself, and
the TextContexts.
Make this private and make the TextContexts that need it friends of this class?

[joshualitt, 2015-03-18 17:57:05]

On 2015/03/18 17:44:17, jvanverth1 wrote:
> Seems reasonable, just one comment.
> 
> https://codereview.chromium.org/1012143005/diff/1/src/gpu/SkGpuDevice.h
> File src/gpu/SkGpuDevice.h (right):
> 
>
https://codereview.chromium.org/1012143005/diff/1/src/gpu/SkGpuDevice.h#newco...
> src/gpu/SkGpuDevice.h:126: // This call is *ONLY* for SkGpuDevice itself, and
> the TextContexts.
> Make this private and make the TextContexts that need it friends of this
class?

feedback inc

[robertphillips, 2015-03-18 18:09:41]

lgtm

https://codereview.chromium.org/1012143005/diff/20001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1012143005/diff/20001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:641: 
pass 'rect' by reference ?

[jvanverth1, 2015-03-18 18:10:07]

LGTM + one last comment

https://codereview.chromium.org/1012143005/diff/20001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1012143005/diff/20001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:643: return clipBounds.isEmpty() ||
!SkIRect::Intersects(clipBounds, rect);
Need to check if second argument "rect" is empty here (like in
SkRegion::quickReject()).

[joshualitt, 2015-03-18 18:34:33]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-03-18 18:34:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
jvanverth@google.com, robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1012143005/#ps40001
(title: "feedback inc")

[commit-bot: I haz the power, 2015-03-18 18:34:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1012143005/40001

[commit-bot: I haz the power, 2015-03-18 18:49:16]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5efb8b8407c956b7fbb85236f3f538f2a104fe98