Issue 101213002: Fix windows build with disable_nacl=1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101213002: Fix windows build with disable_nacl=1 (Closed)

Created:
7 years ago by shinyak

Modified:
7 years ago

Reviewers:
Mark Seaborn, ukai, jochen (gone - plz use gerrit), Cait (Slow)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

switches::kNaClBrokerProcess and switches::kNaClLoaderProcess are only defined when disable_nacl=0. So we should skip them when disable_nacl=1. BUG=325019 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238380

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	chrome/common/chrome_paths_win.cc	View	1	1 chunk	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

shinyak

Hi, We're seeing an link error when disable_nacl=1. Could you check this?

7 years ago (2013-12-03 07:30:37 UTC) #1

ukai

lgtm https://codereview.chromium.org/101213002/diff/1/chrome/common/chrome_paths_win.cc File chrome/common/chrome_paths_win.cc (right): https://codereview.chromium.org/101213002/diff/1/chrome/common/chrome_paths_win.cc#newcode124 chrome/common/chrome_paths_win.cc:124: process_type == switches::kNaClLoaderProcess) nit: if (...) { return ...

7 years ago (2013-12-03 08:04:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shinyak@chromium.org/101213002/20001

7 years ago (2013-12-03 09:36:39 UTC) #5

Message was sent while issue was closed.

Change committed as 238380

Expand Messages | Collapse Messages