Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1012103002: Delegate throwing in RegExpExecStub to CEntryStub. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Delegate throwing in RegExpExecStub to CEntryStub. This ensures that there is only one stub that deals with unwinding the stack. Having more than one place containing that logic is brittle and error prone, especially when it is a corner case only for RangeErrors. R=titzer@chromium.org TEST=mjsunit/regress/regress-crbug-467047 BUG=chromium:467047 LOG=N Committed: https://crrev.com/86b391ecad592eeff68b13814241017811fdee2c Cr-Commit-Position: refs/heads/master@{#27243}

Patch Set 1 #

Patch Set 2 : Fix ARM64 compilation. #

Patch Set 3 : Ported to all the architectures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -444 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +50 lines, -57 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 3 chunks +55 lines, -63 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +45 lines, -52 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 chunks +49 lines, -56 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 chunks +49 lines, -56 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 2 3 chunks +49 lines, -57 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +44 lines, -51 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 2 3 chunks +45 lines, -52 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-467047.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-17 15:00:37 UTC) #1
titzer
lgtm, Do we do MIPS?
5 years, 9 months ago (2015-03-17 15:10:31 UTC) #2
Michael Starzinger
Ported to all the architectures. Landing.
5 years, 9 months ago (2015-03-17 15:27:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012103002/40001
5 years, 9 months ago (2015-03-17 15:27:58 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-17 15:49:32 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 15:49:54 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/86b391ecad592eeff68b13814241017811fdee2c
Cr-Commit-Position: refs/heads/master@{#27243}

Powered by Google App Engine
This is Rietveld 408576698