Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6825)

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 1012093005: [Password Manager] Offer to save when an iframe is detached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change upstream Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/password/frame_detached_on_submit.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 235e1c6ee31bc9e587c6f1e439eb40aab91e6559..65ecd63a643a05949e276ff033cd30f416c7b2dd 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -1774,3 +1774,30 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
observer.Wait();
EXPECT_TRUE(prompt_observer->IsShowingPrompt());
}
+
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+ SaveWhenIFrameDestroyedOnFormSubmit) {
+ NavigateToFile("/password/frame_detached_on_submit.html");
+
+ // Need to pay attention for a message that XHR has finished since there
+ // is no navigation to wait for.
+ content::DOMMessageQueue message_queue;
+
+ scoped_ptr<PromptObserver> prompt_observer(
+ PromptObserver::Create(WebContents()));
+ std::string fill_and_submit =
+ "var iframe = document.getElementById('login_iframe');"
+ "var frame_doc = iframe.contentDocument;"
+ "frame_doc.getElementById('username_field').value = 'temp';"
+ "frame_doc.getElementById('password_field').value = 'random';"
+ "frame_doc.getElementById('submit_button').click();";
+
+ ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
+ std::string message;
+ while (message_queue.WaitForMessage(&message)) {
+ if (message == "\"SUBMISSION_FINISHED\"")
+ break;
+ }
+
+ EXPECT_TRUE(prompt_observer->IsShowingPrompt());
+}
« no previous file with comments | « no previous file | chrome/test/data/password/frame_detached_on_submit.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698