Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1012093005: [Password Manager] Offer to save when an iframe is detached (Closed)

Created:
5 years, 9 months ago by Garrett Casto
Modified:
5 years, 9 months ago
Reviewers:
vabr (Chromium), dvadym
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Offer to save when an iframe is detached If the user has already entered data into a form and the frame containing it is detached, prompt to save. This fixes password saving on Sears.com, as they perform authentication by removing an iframe containing the login information when submission is successful. BUG=450806 Committed: https://crrev.com/92a33acc60e555d9a45cc8f6db686a4007173057 Cr-Commit-Position: refs/heads/master@{#321486}

Patch Set 1 #

Patch Set 2 : Change upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
A chrome/test/data/password/frame_detached_on_submit.html View 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/test/data/password/inner_frame.html View 1 chunk +18 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Garrett Casto
Not that this CL depends on https://codereview.chromium.org/1012853002/ which still hasn't landed yet.
5 years, 9 months ago (2015-03-18 07:22:26 UTC) #2
vabr (Chromium)
LGTM!
5 years, 9 months ago (2015-03-18 08:33:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1012093005/20001
5 years, 9 months ago (2015-03-19 22:57:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 01:25:50 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 01:26:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92a33acc60e555d9a45cc8f6db686a4007173057
Cr-Commit-Position: refs/heads/master@{#321486}

Powered by Google App Engine
This is Rietveld 408576698