Autofill: Improve the order of heuristics to apply when inferring labels

Autofill: Improve the order of heuristics to apply when inferring labels

Right now the order is somewhat arbitrary. Instead, look at the types of
a field's ancestors to determine the order.

BUG=465587
Committed: https://crrev.com/cd1401c2d863a44ea405a313e94d8fcbfbfb7ada
Cr-Commit-Position: refs/heads/master@{#321249}

[Lei Zhang, 2015-03-18 00:29:40]

thestig@chromium.org changed reviewers:
+ estade@chromium.org

[Lei Zhang, 2015-03-18 00:48:39]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2015-03-18 00:58:08]

Patchset #1 (id:20001) has been deleted

[Lei Zhang, 2015-03-18 00:58:59]

All the labels that we lost as a result of this CL were not very good in quality
anyway.

[Lei Zhang, 2015-03-18 01:39:43]

See patch set 2, which removes InferLabelFromLabelTag(() since
MatchLabelsAndFields() + WebLabelElement::correspondingControl() already does
that.

[Evan Stade, 2015-03-18 01:51:29]

lgtm

https://codereview.chromium.org/1012093004/diff/60001/components/autofill/con...
File components/autofill/content/renderer/form_autofill_util.cc (right):

https://codereview.chromium.org/1012093004/diff/60001/components/autofill/con...
components/autofill/content/renderer/form_autofill_util.cc:139: return (tag_name
== "DD" ||
nit: parens are unnecessary

[Lei Zhang, 2015-03-18 02:02:18]

https://codereview.chromium.org/1012093004/diff/60001/components/autofill/con...
File components/autofill/content/renderer/form_autofill_util.cc (right):

https://codereview.chromium.org/1012093004/diff/60001/components/autofill/con...
components/autofill/content/renderer/form_autofill_util.cc:139: return (tag_name
== "DD" ||
On 2015/03/18 01:51:29, Evan Stade wrote:
> nit: parens are unnecessary

but the parens tells my editor to line up the entries when auto-indenting

[Lei Zhang, 2015-03-18 23:02:23]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-03-18 23:03:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1012093004/60001

[commit-bot: I haz the power, 2015-03-19 00:28:07]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-03-19 00:28:51]

Patchset 2 (id:??) landed as
https://crrev.com/cd1401c2d863a44ea405a313e94d8fcbfbfb7ada
Cr-Commit-Position: refs/heads/master@{#321249}