Resolve new GAIA flow's infinite loop.

chrome/browser/resources/gaia_auth_host/authenticator.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview An UI component to authenciate to Chrome. The component hosts
  * IdP web pages in a webview. A client who is interested in monitoring
  * authentication events should pass a listener object of type
  * cr.login.GaiaAuthHost.Listener as defined in this file. After initialization,
  * call {@code load} to start the authentication flow.
@@ skipping 107 matching lines @@
         'focus', this.onFocus_.bind(this), false);
     window.addEventListener(
         'popstate', this.onPopState_.bind(this), false);
   }
 
   // TODO(guohui,xiyuan): no need to inherit EventTarget once we deprecate the
   // old event-based signin flow.
   Authenticator.prototype = Object.create(cr.EventTarget.prototype);
 
   /**
+   * Reinitializes authentication parameters so that a failed login attempt
+   * would not result in an infinite loop.
+   */
+  Authenticator.prototype.clearCredentials_ = function() {

[Roman Sorokin (ftl), 2015/03/17 17:00:41]

Could we call this function in the constructor? We make the same init there.

[Ivan Podogov, 2015/03/18 07:36:20]

That was my initial thought, but Dmitry asked me to keep it this way, so that
all the variables that are added in the constructor would be listed together.
Also, if we will add/remove anything from this function, we'll have to keep
track on what we change, and always update the constructor accordingly, which is
not a convenient way.

+    this.email_ = null;
+    this.gaiaId_ = null;
+    this.password_ = null;
+    this.oauth_code_ = null;
+    this.chooseWhatToSync_ = false;
+    this.skipForNow_ = false;
+    this.sessionIndex_ = null;
+    this.trusted_ = true;
+    this.authFlow_ = AuthFlow.DEFAULT;
+    this.loaded_ = false;
+  };
+
+  /**
    * Loads the authenticator component with the given parameters.
    * @param {AuthMode} authMode Authorization mode.
    * @param {Object} data Parameters for the authorization flow.
    */
   Authenticator.prototype.load = function(authMode, data) {
+    this.clearCredentials_();
     this.idpOrigin_ = data.gaiaUrl || IDP_ORIGIN;
     this.continueUrl_ = data.continueUrl || CONTINUE_URL;
     this.continueUrlWithoutParams_ =
         this.continueUrl_.substring(0, this.continueUrl_.indexOf('?')) ||
         this.continueUrl_;
     this.isConstrainedWindow_ = data.constrained == '1';
     this.isMinuteMaidChromeOS = data.isMinuteMaidChromeOS;
 
     this.initialFrameUrl_ = this.constructInitialFrameUrl_(data);
     this.reloadUrl_ = data.frameUrl || this.initialFrameUrl_;
-    this.authFlow_ = AuthFlow.DEFAULT;
 
     this.webview_.src = this.reloadUrl_;
-
-    this.loaded_ = false;
   };
 
   /**
    * Reloads the authenticator component.
    */
   Authenticator.prototype.reload = function() {
+    this.clearCredentials_();
     this.webview_.src = this.reloadUrl_;
-    this.authFlow_ = AuthFlow.DEFAULT;
-    this.loaded_ = false;
   };
 
   Authenticator.prototype.constructInitialFrameUrl_ = function(data) {
     var url = this.idpOrigin_ + (data.gaiaPath || IDP_PATH);
 
     if (this.isMinuteMaidChromeOS) {
       if (data.chromeType)
         url = appendParam(url, 'chrometype', data.chromeType);
       if (data.clientId)
         url = appendParam(url, 'client_id', data.clientId);
@@ skipping 236 matching lines @@
   Authenticator.AuthFlow = AuthFlow;
   Authenticator.AuthMode = AuthMode;
   Authenticator.SUPPORTED_PARAMS = SUPPORTED_PARAMS;
 
   return {
     // TODO(guohui, xiyuan): Rename GaiaAuthHost to Authenticator once the old
     // iframe-based flow is deprecated.
     GaiaAuthHost: Authenticator
   };
 });