remoting/webapp/base/js/application.js - Issue 1012073006: [Webapp Refactor] Removes the client plugin on disconnect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/base/js/application.js

Issue 1012073006: [Webapp Refactor] Removes the client plugin on disconnect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/base/js/application.js

diff --git a/remoting/webapp/base/js/application.js b/remoting/webapp/base/js/application.js

index 82b64534c4a50a56a79271531acecc8fbb2c3b4e..77d6ff0a9ef10d1737ae31610b6945fe664b2ca2 100644

--- a/remoting/webapp/base/js/application.js

+++ b/remoting/webapp/base/js/application.js

@@ -219,8 +219,7 @@ remoting.Application.prototype.onClientStateChange_ = function(state) {

base.dispose(this.sessionConnectedHooks_);

this.sessionConnectedHooks_= null;

- remoting.clientSession.dispose();

- remoting.clientSession = null;

+ this.sessionConnector_.removePlugin();

garykac 2015/03/18 20:13:14 This doesn't just remove the plugin - it frees the

kelvinp 2015/03/18 20:43:36 Done.

};

/** @private */

« no previous file with comments | « no previous file | remoting/webapp/crd/js/client_session.js » ('j') | remoting/webapp/crd/js/client_session.js » ('J')