[Webapp Refactor] Removes the client plugin on disconnect.

remoting/webapp/base/js/application.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Interface abstracting the Application functionality.
  */
 
 'use strict';
@@ skipping 201 matching lines @@
     default:
       console.error('Unexpected client plugin state: ' + state.current);
       // This should only happen if the web-app and client plugin get out of
       // sync, so MISSING_PLUGIN is a suitable error.
       this.onError(new remoting.Error(remoting.Error.Tag.MISSING_PLUGIN));
       break;
   }
 
   base.dispose(this.sessionConnectedHooks_);
   this.sessionConnectedHooks_= null;
-  remoting.clientSession.dispose();
-  remoting.clientSession = null;
+  this.sessionConnector_.removePlugin();

[garykac, 2015/03/18 20:13:14]

This doesn't just remove the plugin - it frees the session as well.

I think that something like 'closeSession' would be more descriptive.

[kelvinp, 2015/03/18 20:43:36]

Done.

 };
 
 /** @private */
 remoting.Application.prototype.updateStatistics_ = function() {
   var perfstats = remoting.clientSession.getPerfStats();
   remoting.stats.update(perfstats);
   remoting.clientSession.logStatistics(perfstats);
 };
 
 
@@ skipping 85 matching lines @@
  * Perform any application-specific cleanup before exiting. This is called in
  * lieu of start() if the user declines the app permissions, and will usually
  * be called immediately prior to exiting, although delegates should not rely
  * on this.
  */
 remoting.Application.Delegate.prototype.handleExit = function() {};
 
 
 /** @type {remoting.Application} */
 remoting.app = null;