[Webapp Refactor] Removes the client plugin on disconnect.

[Webapp Refactor] Removes the client plugin on Disconnect.

The existing implementation does not removes the clientPlugin
from the DOM upon a disconnect. This CL fixes it.

It also moves the disconnect logic from clientSession.dispose()
to clientSession.disconnect() as the name suggests.

BUG=465878
Committed: https://crrev.com/018be1d6b0eef9af943eb87217b2912f00c05c21
Cr-Commit-Position: refs/heads/master@{#321233}

[kelvinp, 2015-03-18 20:05:45]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@google.com

[kelvinp, 2015-03-18 20:08:27]

kelvinp@chromium.org changed reviewers:
+ garykac@chromium.org
- jamiewalch@google.com

[kelvinp, 2015-03-18 20:08:36]

PTAL

https://codereview.chromium.org/1012073006/diff/1/remoting/webapp/crd/js/clie...
File remoting/webapp/crd/js/client_session.js (left):

https://codereview.chromium.org/1012073006/diff/1/remoting/webapp/crd/js/clie...
remoting/webapp/crd/js/client_session.js:246:
remoting.ClientSession.prototype.removePlugin = function() {
This is a misleading name as it doesn't remove the plugin at all.  Renamed to
dispose() instead.

[garykac, 2015-03-18 20:13:14]

https://codereview.chromium.org/1012073006/diff/1/remoting/webapp/base/js/app...
File remoting/webapp/base/js/application.js (right):

https://codereview.chromium.org/1012073006/diff/1/remoting/webapp/base/js/app...
remoting/webapp/base/js/application.js:222:
this.sessionConnector_.removePlugin();
This doesn't just remove the plugin - it frees the session as well.

I think that something like 'closeSession' would be more descriptive.

[kelvinp, 2015-03-18 20:43:36]

PTAL

https://codereview.chromium.org/1012073006/diff/1/remoting/webapp/base/js/app...
File remoting/webapp/base/js/application.js (right):

https://codereview.chromium.org/1012073006/diff/1/remoting/webapp/base/js/app...
remoting/webapp/base/js/application.js:222:
this.sessionConnector_.removePlugin();
On 2015/03/18 20:13:14, garykac wrote:
> This doesn't just remove the plugin - it frees the session as well.
> 
> I think that something like 'closeSession' would be more descriptive.

Done.

[garykac, 2015-03-18 20:54:59]

lgtm

[kelvinp, 2015-03-18 21:49:55]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-03-18 21:50:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1012073006/20001

[commit-bot: I haz the power, 2015-03-18 23:31:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-18 23:31:59]

Patchset 2 (id:??) landed as
https://crrev.com/018be1d6b0eef9af943eb87217b2912f00c05c21
Cr-Commit-Position: refs/heads/master@{#321233}