Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/test/chromedriver/commands.cc

Issue 101203012: [chromedriver] Add an error autoreporting feature that automatically raises errors from browser logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from review Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/client/command_executor.py ('k') | chrome/test/chromedriver/logging.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/commands.cc
diff --git a/chrome/test/chromedriver/commands.cc b/chrome/test/chromedriver/commands.cc
index 756bf549c702f9dd4fbd1ac13dc8a4eaaa47426b..af71207cadbeb775634f65905cbec78f5d5133b8 100644
--- a/chrome/test/chromedriver/commands.cc
+++ b/chrome/test/chromedriver/commands.cc
@@ -194,6 +194,12 @@ void ExecuteSessionCommandOnSessionThread(
<< (result.length() ? " " + result : "");
}
+ if (status.IsOk() && session->auto_reporting_enabled) {
+ std::string message = session->GetFirstBrowserError();
+ if (!message.empty())
+ status = Status(kUnknownError, message);
+ }
+
cmd_task_runner->PostTask(
FROM_HERE,
base::Bind(callback_on_cmd, status, base::Passed(&value), session->id));
« no previous file with comments | « chrome/test/chromedriver/client/command_executor.py ('k') | chrome/test/chromedriver/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698