[chromedriver] Add an error autoreporting feature that automatically raises errors from browser logs

chrome/test/chromedriver/window_commands.cc

Index: chrome/test/chromedriver/window_commands.cc
diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc
index 266361b4c9555dfc49b4a62e1a71f66d7ab5568f..22638e16f02a18a9dfc1b72114f10579b3f6f4bd 100644
--- a/chrome/test/chromedriver/window_commands.cc
+++ b/chrome/test/chromedriver/window_commands.cc
@@ -233,6 +233,13 @@ Status ExecuteWindowCommand(
     return nav_status;
   if (status.code() == kUnexpectedAlertOpen)
     return Status(kOk);
+
+  if (status.IsOk() && session->auto_reporting_enabled) {

[chrisgao (Use stgao instead), 2014/01/09 22:11:55]

We already check for errors in method ExecuteSessionCommandOnSessionThread of
file chrome/test/chromedriver/commands.cc. Why do we need to check again here?

A window command will be wrapped up into a session command. That's say, if a
window command is executed, we will check for errors twice.

[samuong, 2014/01/16 00:29:28]

Done.

+    std::string message = session->GetFirstBrowserError();
+    if (!message.empty())
+      status = Status(kUnknownError, message);
+  }
+
   return status;
 }