Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5700)

Unified Diff: chrome/test/chromedriver/logging.h

Issue 101203012: [chromedriver] Add an error autoreporting feature that automatically raises errors from browser logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/logging.h
diff --git a/chrome/test/chromedriver/logging.h b/chrome/test/chromedriver/logging.h
index 505ede8357a1709b7f7498b4f107540db9a0c4f2..eb2cde881ca6ac460cbb1232792848ea086b1f41 100644
--- a/chrome/test/chromedriver/logging.h
+++ b/chrome/test/chromedriver/logging.h
@@ -39,6 +39,10 @@ class WebDriverLog : public Log {
// creates and owns a new empty ListValue for further accumulation.
scoped_ptr<base::ListValue> GetAndClearEntries();
+ // Finds the first error message in the log and returns it. If none exist,
chrisgao (Use stgao instead) 2014/01/09 22:11:55 nit: exist -> exists ?
samuong 2014/01/16 00:29:28 I think it's "if none exist" or "if nothing exists
+ // returns an empty string. Does not clear entries.
+ std::string GetFirstErrorMessage() const;
chrisgao (Use stgao instead) 2014/01/09 22:11:55 What's the consideration behind only returning the
samuong 2014/01/16 00:29:28 The first error message gets returned to the clien
+
// Translates a Log entry level into a WebDriver level and stores the entry.
virtual void AddEntryTimestamped(const base::Time& timestamp,
Level level,

Powered by Google App Engine
This is Rietveld 408576698