[chromedriver] Add an error autoreporting feature that automatically raises errors from browser logs

chrome/test/chromedriver/window_commands.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/window_commands.h"
 
 #include <list>
 #include <string>
 
 #include "base/callback.h"
@@ skipping 215 matching lines @@
   }
 
   nav_status = web_view->WaitForPendingNavigations(
       session->GetCurrentFrameId(), session->page_load_timeout, true);
 
   if (status.IsOk() && nav_status.IsError() &&
       nav_status.code() != kUnexpectedAlertOpen)
     return nav_status;
   if (status.code() == kUnexpectedAlertOpen)
     return Status(kOk);
+
+  if (status.IsOk() && session->auto_reporting_enabled) {

[chrisgao (Use stgao instead), 2014/01/09 22:11:55]

We already check for errors in method ExecuteSessionCommandOnSessionThread of
file chrome/test/chromedriver/commands.cc. Why do we need to check again here?

A window command will be wrapped up into a session command. That's say, if a
window command is executed, we will check for errors twice.

[samuong, 2014/01/16 00:29:28]

Done.

+    std::string message = session->GetFirstBrowserError();
+    if (!message.empty())
+      status = Status(kUnknownError, message);
+  }
+
   return status;
 }
 
 Status ExecuteGet(
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value) {
   std::string url;
   if (!params.GetString("url", &url))
@@ skipping 618 matching lines @@
   return status;
 }
 
 Status ExecuteTakeHeapSnapshot(
     Session* session,
     WebView* web_view,
     const base::DictionaryValue& params,
     scoped_ptr<base::Value>* value) {
   return web_view->TakeHeapSnapshot(value);
 }