[chromedriver] Add an error autoreporting feature that automatically raises errors from browser logs

chrome/test/chromedriver/logging.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/logging.h"
 
 #include <stdio.h>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 132 matching lines @@
   VLOG(1) << "Log type '" << type_ << "' lost "
           << entries_->GetSize() << " entries on destruction";
 }
 
 scoped_ptr<base::ListValue> WebDriverLog::GetAndClearEntries() {
   scoped_ptr<base::ListValue> ret(entries_.release());
   entries_.reset(new base::ListValue());
   return ret.Pass();
 }
 
+std::string WebDriverLog::GetFirstErrorMessage() const {

[chrisgao (Use stgao instead), 2014/01/09 22:11:55]

How do you handle error messages resulted from the page of navigation1 while we
are on the page of navigation2?

I found there is one DevTools event "Console.messagesCleared". You may have a
check.

[samuong, 2014/01/16 00:29:28]

In this case the error from navigation1 will get autoreported, even though we're
on the page of navigation2. I think this is the best way to do it as it ensures
that error messages don't get missed.

Chromedriver already prepends a URL to each error message, so this should make
it obvious to users which page an error message belongs to.

+  for (base::ListValue::iterator it = entries_->begin();
+       it != entries_->end();
+       ++it) {
+    base::DictionaryValue* log_entry = NULL;
+    (*it)->GetAsDictionary(&log_entry);
+    if (log_entry != NULL) {
+      std::string level;
+      if (log_entry->GetString("level", &level)) {
+        if (level.compare(kLevelToName[Log::kError]) == 0) {

[chrisgao (Use stgao instead), 2014/01/09 22:11:55]

level == kLevelToName[Log::kError] ?

[samuong, 2014/01/16 00:29:28]

Done. Obviously I'm still working on kicking the Java habit.

+          std::string message;
+          if (log_entry->GetString("message", &message))
+            return message;

[chrisgao (Use stgao instead), 2014/01/09 22:11:55]

If we do not clear the error message from the list and the client side doesn't
pull the log(As we return a UnknownError, the client side couldn't tell the
error from others.), in all following commands, we will always hit the same
error or maybe a newer one.

Any idea to handle it?

[samuong, 2014/01/16 00:29:28]

When an error is auto-reported, I think most clients will either bail or call
GET_LOGS (which will clear any subsequent error messages). But if they don't,
then I agree that it is a bit weird to throw the same error at them over and
over again.

As you suggested, let's address this in a followup CL, so that we can discuss
exactly how chromedriver should behave in this situation.

+        }
+      }
+    }
+  }
+  return "";

[chrisgao (Use stgao instead), 2014/01/09 22:11:55]

"" -> std::string()

[samuong, 2014/01/16 00:29:28]

Done.

+}
+
 void WebDriverLog::AddEntryTimestamped(const base::Time& timestamp,
                                        Log::Level level,
                                        const std::string& source,
                                        const std::string& message) {
   if (level < min_level_)
     return;
 
   scoped_ptr<base::DictionaryValue> log_entry_dict(new base::DictionaryValue());
   log_entry_dict->SetDouble("timestamp",
                             static_cast<int64>(timestamp.ToJsTime()));
@@ skipping 88 matching lines @@
       new WebDriverLog(WebDriverLog::kBrowserType, browser_log_level);
   logs.push_back(browser_log);
   // If the level is OFF, don't even bother listening for DevTools events.
   if (browser_log_level != Log::kOff)
     listeners.push_back(new ConsoleLogger(browser_log));
 
   out_logs->swap(logs);
   out_listeners->swap(listeners);
   return Status(kOk);
 }