Allow app_shell to run past extension manifest parsing

apps/shell/shell_extension_system.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/shell/shell_extension_system.h"
 
+#include <string>
+
 #include "base/command_line.h"
+#include "base/files/file_path.h"
+#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_prefs.h"
+#include "chrome/common/extensions/extension_file_util.h"
 #include "content/public/browser/browser_context.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/notification_source.h"
 #include "extensions/browser/event_router.h"
+#include "extensions/browser/extension_registry.h"
 #include "extensions/browser/lazy_background_task_queue.h"
 #include "extensions/browser/process_manager.h"
 
 using content::BrowserContext;
 
 namespace extensions {
 
 ShellExtensionSystem::ShellExtensionSystem(BrowserContext* browser_context)
     : browser_context_(browser_context) {
 }
 
 ShellExtensionSystem::~ShellExtensionSystem() {
 }
 
+bool ShellExtensionSystem::LoadAndLaunchApp(const base::FilePath& app_dir) {
+  std::string load_error;
+  scoped_refptr<Extension> extension =
+      extension_file_util::LoadExtension(app_dir,
+                                         extensions::Manifest::COMMAND_LINE,
+                                         Extension::NO_FLAGS,
+                                         &load_error);
+  if (!extension) {
+    LOG(ERROR) << "Loading extension at " << app_dir.value()
+        << " failed with: " << load_error;
+    return false;
+  }
+
+  ExtensionRegistry::Get(browser_context_)->AddEnabled(extension);
+
+  // TODO(jamescook): If RegisterExtensionWithRequestContexts() did something,
+  // this would be the place to call it.
+
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_EXTENSION_LOADED,
+      content::Source<BrowserContext>(browser_context_),
+      content::Details<const Extension>(extension));
+
+  // Inform the rest of the extensions system to start.
+  ready_.Signal();
+  LOG(WARNING) << "-----------------------------------";
+  LOG(WARNING) << "app_shell is expected to crash now.";
+  LOG(WARNING) << "-----------------------------------";
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_EXTENSIONS_READY,
+      content::Source<BrowserContext>(browser_context_),
+      content::NotificationService::NoDetails());
+
+  return true;
+}
+
 void ShellExtensionSystem::Shutdown() {
 }
 
 void ShellExtensionSystem::InitForRegularProfile(bool extensions_enabled) {
   lazy_background_task_queue_.reset(
       new LazyBackgroundTaskQueue(browser_context_));
   event_router_.reset(
       new EventRouter(browser_context_, ExtensionPrefs::Get(browser_context_)));
   process_manager_.reset(ProcessManager::Create(browser_context_));
 }
 
 ExtensionService* ShellExtensionSystem::extension_service() {
-  // This class only has an ExtensionServiceInterface.
+  NOTREACHED();
   return NULL;
 }
 
 ManagementPolicy* ShellExtensionSystem::management_policy() {
   return NULL;
 }
 
 UserScriptMaster* ShellExtensionSystem::user_script_master() {
   return NULL;
 }
@@ skipping 45 matching lines @@
 void ShellExtensionSystem::UnregisterExtensionWithRequestContexts(
     const std::string& extension_id,
     const UnloadedExtensionInfo::Reason reason) {
 }
 
 const OneShotEvent& ShellExtensionSystem::ready() const {
   return ready_;
 }
 
 }  // namespace extensions