Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 101203006: Fix Blink dependencies in build files. (Closed)

Created:
6 years, 11 months ago by davidben
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix Blink dependencies in build files. Many dependencies weren't declared, resulting in files not being built with Blink's direct_dependent_settings. This is needed for https://codereview.chromium.org/123133006/ to land. - password_form_conversion_utils.cc includes Blink headers, so depend autofill_content_renderer on Blink. - ppb_nacl_private_impl.cc includes Blink headers, so depend nacl_renderer on Blink. - render_view_test.h is a public content/ header with includes Blink headers, so add Blink to test_support_content's export_dependent_settings. - Test targets in chrome/ all depend on test_support_content via test_support_common, so add test_support_content to test_support_common's export_dependent_settings. BUG=331386 TEST=builds Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
davidben
This is the first of a three-legged change. 1. This CL: Fix some build dependencies ...
6 years, 11 months ago (2014-01-06 22:41:17 UTC) #1
davidben
On 2014/01/06 22:41:17, David Benjamin wrote: > This is the first of a three-legged change. ...
6 years, 11 months ago (2014-01-06 23:04:10 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-07 10:19:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/101203006/1
6 years, 11 months ago (2014-01-07 14:19:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/101203006/1
6 years, 11 months ago (2014-01-07 15:27:06 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 15:49:57 UTC) #6
Message was sent while issue was closed.
Change committed as 243297

Powered by Google App Engine
This is Rietveld 408576698