Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: test/cctest/test-mark-compact.cc

Issue 1012023002: Merge old data and pointer space. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-heap.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-mark-compact.cc
diff --git a/test/cctest/test-mark-compact.cc b/test/cctest/test-mark-compact.cc
index 5006c103d7a63e04951a01999f8652f3b61518df..1674afc2082b67a96e12ee5540fa5792f516e4a3 100644
--- a/test/cctest/test-mark-compact.cc
+++ b/test/cctest/test-mark-compact.cc
@@ -97,7 +97,7 @@ TEST(Promotion) {
heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
// Array now sits in the old space
- CHECK(heap->InSpace(*array, OLD_POINTER_SPACE));
+ CHECK(heap->InSpace(*array, OLD_SPACE));
}
@@ -119,10 +119,10 @@ TEST(NoPromotion) {
CHECK(heap->InSpace(*array, NEW_SPACE));
// Simulate a full old space to make promotion fail.
- SimulateFullSpace(heap->old_pointer_space());
+ SimulateFullSpace(heap->old_space());
// Call mark compact GC, and it should pass.
- heap->CollectGarbage(OLD_POINTER_SPACE);
+ heap->CollectGarbage(OLD_SPACE);
}
@@ -138,7 +138,7 @@ TEST(MarkCompactCollector) {
Handle<GlobalObject> global(isolate->context()->global_object());
// call mark-compact when heap is empty
- heap->CollectGarbage(OLD_POINTER_SPACE, "trigger 1");
+ heap->CollectGarbage(OLD_SPACE, "trigger 1");
// keep allocating garbage in new space until it fails
const int arraysize = 100;
@@ -165,7 +165,7 @@ TEST(MarkCompactCollector) {
factory->NewJSObject(function);
}
- heap->CollectGarbage(OLD_POINTER_SPACE, "trigger 4");
+ heap->CollectGarbage(OLD_SPACE, "trigger 4");
{ HandleScope scope(isolate);
Handle<String> func_name = factory->InternalizeUtf8String("theFunction");
@@ -183,7 +183,7 @@ TEST(MarkCompactCollector) {
JSReceiver::SetProperty(obj, prop_name, twenty_three, SLOPPY).Check();
}
- heap->CollectGarbage(OLD_POINTER_SPACE, "trigger 5");
+ heap->CollectGarbage(OLD_SPACE, "trigger 5");
{ HandleScope scope(isolate);
Handle<String> obj_name = factory->InternalizeUtf8String("theObject");
@@ -308,7 +308,7 @@ TEST(ObjectGroups) {
g2c1.location());
}
// Do a full GC
- heap->CollectGarbage(OLD_POINTER_SPACE);
+ heap->CollectGarbage(OLD_SPACE);
// All object should be alive.
CHECK_EQ(0, NumberOfWeakCalls);
@@ -335,7 +335,7 @@ TEST(ObjectGroups) {
g2c1.location());
}
- heap->CollectGarbage(OLD_POINTER_SPACE);
+ heap->CollectGarbage(OLD_SPACE);
// All objects should be gone. 5 global handles in total.
CHECK_EQ(5, NumberOfWeakCalls);
@@ -348,7 +348,7 @@ TEST(ObjectGroups) {
reinterpret_cast<void*>(&g2c1_and_id),
&WeakPointerCallback);
- heap->CollectGarbage(OLD_POINTER_SPACE);
+ heap->CollectGarbage(OLD_SPACE);
CHECK_EQ(7, NumberOfWeakCalls);
}
« no previous file with comments | « test/cctest/test-heap.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698