Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1011963003: Modify behavior of --bypass-app-banner-engagement-checks flag. (Closed)

Created:
5 years, 9 months ago by benwells
Modified:
5 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify behavior of --bypass-app-banner-engagement-checks flag. This flag now does not bypass the checks for whether the app has been added to the homescreen or not. BUG=467374 Committed: https://crrev.com/7f20516eaeaa5fcf2e0a685a3b048c1fdb9a856f Cr-Commit-Position: refs/heads/master@{#320968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/banners/app_banner_settings_helper.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
5 years, 9 months ago (2015-03-17 06:33:30 UTC) #2
gone
lgtm
5 years, 9 months ago (2015-03-17 16:55:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011963003/1
5 years, 9 months ago (2015-03-17 20:49:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 20:54:46 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 20:55:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f20516eaeaa5fcf2e0a685a3b048c1fdb9a856f
Cr-Commit-Position: refs/heads/master@{#320968}

Powered by Google App Engine
This is Rietveld 408576698