Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6377)

Unified Diff: chrome/browser/search/hotword_service.cc

Issue 1011963002: Hotword: Decouple sometimes and always on prefs when disabling. They can both exist independently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/hotword_service.cc
diff --git a/chrome/browser/search/hotword_service.cc b/chrome/browser/search/hotword_service.cc
index 7560a50c93ba348e54618446b38439b29fc2cb16..1b9231efa98786f6c08a4a552126b34bd968aa3f 100644
--- a/chrome/browser/search/hotword_service.cc
+++ b/chrome/browser/search/hotword_service.cc
@@ -789,7 +789,8 @@ void HotwordService::DisableHotwordPreferences() {
if (IsSometimesOnEnabled()) {
if (profile_->GetPrefs()->HasPrefPath(prefs::kHotwordSearchEnabled))
Anand Mistry (off Chromium) 2015/03/17 03:05:40 Get rid of these two HasPrefPath checks. IsFooEnab
kcarattini 2015/03/17 04:07:39 Done.
profile_->GetPrefs()->SetBoolean(prefs::kHotwordSearchEnabled, false);
- } else if (IsAlwaysOnEnabled()) {
+ }
+ if (IsAlwaysOnEnabled()) {
if (profile_->GetPrefs()->HasPrefPath(
prefs::kHotwordAlwaysOnSearchEnabled)) {
profile_->GetPrefs()->SetBoolean(prefs::kHotwordAlwaysOnSearchEnabled,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698