components/history/core/browser/history_backend.h - Issue 1011943003: Don't treat back/forwards as typed transitions in history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_backend.h

Issue 1011943003: Don't treat back/forwards as typed transitions in history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/history/core/browser/expire_history_backend.cc ('k') | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/history_backend.h

diff --git a/components/history/core/browser/history_backend.h b/components/history/core/browser/history_backend.h

index 6cce8af933dfcfec374f4b79548b935e8a6f9e74..6c54b459df8f204bc306b8455854d991d31e80f3 100644

--- a/components/history/core/browser/history_backend.h

+++ b/components/history/core/browser/history_backend.h

@@ -466,6 +466,8 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,

FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, StripUsernamePasswordTest);

FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, DeleteThumbnailsDatabaseTest);

FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddPageVisitSource);

+ FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddPageVisitBackForward);

+ FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddPageVisitRedirectBackForward);

FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest, AddPageVisitNotLastVisit);

FRIEND_TEST_ALL_PREFIXES(HistoryBackendTest,

AddPageVisitFiresNotificationWithCorrectDetails);

« no previous file with comments | « components/history/core/browser/expire_history_backend.cc ('k') | components/history/core/browser/history_backend.cc » ('j') | no next file with comments »