components/history/core/browser/expire_history_backend.cc - Issue 1011943003: Don't treat back/forwards as typed transitions in history.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/expire_history_backend.cc

Issue 1011943003: Don't treat back/forwards as typed transitions in history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | components/history/core/browser/history_backend.h » ('j') | components/history/core/browser/history_backend.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/expire_history_backend.cc

diff --git a/components/history/core/browser/expire_history_backend.cc b/components/history/core/browser/expire_history_backend.cc

index e115f84eeead8f54f81c07e9ec2737321d499022..e8e2f4402526741aa1ce989246b95d3a68ffc07b 100644

--- a/components/history/core/browser/expire_history_backend.cc

+++ b/components/history/core/browser/expire_history_backend.cc

@@ -394,6 +394,7 @@ void ExpireHistoryBackend::ExpireURLsForVisits(const VisitVector& visits,

if (transition != ui::PAGE_TRANSITION_RELOAD)

cur.visit_count++;

if ((transition == ui::PAGE_TRANSITION_TYPED &&

+ ui::PageTransitionIsNewNavigation(visits[i].transition) &&

!ui::PageTransitionIsRedirect(visits[i].transition)) ||

transition == ui::PAGE_TRANSITION_KEYWORD_GENERATED)

cur.typed_count++;