Don't treat back/forwards as typed transitions in history.

chrome/browser/history/history_backend_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/history_backend.h"
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
@@ skipping 870 matching lines @@
   EXPECT_TRUE(backend_->db()->GetVisitsForURL(url_id, &visits));
   EXPECT_EQ(1U, visits.size());
 
   // But no visible visits.
   visits.clear();
   QueryOptions query_options;
   query_options.max_count = 1;
   backend_->db()->GetVisibleVisitsInRange(query_options, &visits);
   EXPECT_TRUE(visits.empty());
 
+  // Going back to the same entry should not increment the typed count.
+  ui::PageTransition back_transition = ui::PageTransitionFromInt(
+      ui::PAGE_TRANSITION_TYPED | ui::PAGE_TRANSITION_FORWARD_BACK);
+  HistoryAddPageArgs back_request(url, visit_time, NULL, 0, GURL(),
+                                  history::RedirectList(), back_transition,
+                                  history::SOURCE_BROWSED, false);
+  backend_->AddPage(back_request);
+  url_id = backend_->db()->GetRowForURL(url, &row);
+  ASSERT_NE(0, url_id);
+  ASSERT_EQ(1, row.typed_count());
+
   // Expire the visits.
   std::set<GURL> restrict_urls;
   backend_->expire_backend()->ExpireHistoryBetween(restrict_urls,
                                                    visit_time, Time::Now());
 
   // The visit should have been nuked.
   visits.clear();
   EXPECT_TRUE(backend_->db()->GetVisitsForURL(url_id, &visits));
   EXPECT_TRUE(visits.empty());
 
@@ skipping 294 matching lines @@
 
   // Fetch the row information about stripped url from history db.
   VisitVector visits;
   URLID row_id = backend_->db_->GetRowForURL(stripped_url, NULL);
   backend_->db_->GetVisitsForURL(row_id, &visits);
 
   // Check if stripped url is stored in database.
   ASSERT_EQ(1U, visits.size());
 }
 
+TEST_F(HistoryBackendTest, AddPageVisitBackForward) {
+  ASSERT_TRUE(backend_.get());
+
+  GURL url("http://www.google.com");
+
+  // Clear all history.
+  backend_->DeleteAllHistory();
+
+  // Visit the url after typing it.
+  backend_->AddPageVisit(url, base::Time::Now(), 0,
+      ui::PAGE_TRANSITION_TYPED,
+      history::SOURCE_BROWSED);
+
+  // Ensure both the typed count and visit count are 1.
+  VisitVector visits;
+  URLRow row;
+  URLID id = backend_->db()->GetRowForURL(url, &row);
+  ASSERT_TRUE(backend_->db()->GetVisitsForURL(id, &visits));
+  EXPECT_EQ(1, row.typed_count());
+  EXPECT_EQ(1, row.visit_count());
+
+  // Visit the url again via back/forward.
+  backend_->AddPageVisit(url, base::Time::Now(), 0,
+      ui::PageTransitionFromInt(
+          ui::PAGE_TRANSITION_TYPED | ui::PAGE_TRANSITION_FORWARD_BACK),
+      history::SOURCE_BROWSED);
+
+  // Ensure the typed count is still 1 but the visit count is 2.
+  id = backend_->db()->GetRowForURL(url, &row);
+  ASSERT_TRUE(backend_->db()->GetVisitsForURL(id, &visits));
+  EXPECT_EQ(1, row.typed_count());
+  EXPECT_EQ(2, row.visit_count());
+}
+
+TEST_F(HistoryBackendTest, AddPageVisitRedirectBackForward) {
+  ASSERT_TRUE(backend_.get());
+
+  GURL url1("http://www.google.com");
+  GURL url2("http://www.chromium.org");
+
+  // Clear all history.
+  backend_->DeleteAllHistory();
+
+  // Visit a typed URL with a redirect.
+  backend_->AddPageVisit(url1, base::Time::Now(), 0,
+      ui::PAGE_TRANSITION_TYPED,
+      history::SOURCE_BROWSED);
+  backend_->AddPageVisit(url2, base::Time::Now(), 0,
+      ui::PageTransitionFromInt(
+          ui::PAGE_TRANSITION_TYPED | ui::PAGE_TRANSITION_CLIENT_REDIRECT),
+      history::SOURCE_BROWSED);
+
+  // Ensure the redirected URL does not count as typed.
+  VisitVector visits;
+  URLRow row;
+  URLID id = backend_->db()->GetRowForURL(url2, &row);
+  ASSERT_TRUE(backend_->db()->GetVisitsForURL(id, &visits));
+  EXPECT_EQ(0, row.typed_count());
+  EXPECT_EQ(1, row.visit_count());
+
+  // Visit the redirected url again via back/forward.
+  backend_->AddPageVisit(url2, base::Time::Now(), 0,
+      ui::PageTransitionFromInt(
+          ui::PAGE_TRANSITION_TYPED |
+          ui::PAGE_TRANSITION_FORWARD_BACK |
+          ui::PAGE_TRANSITION_CLIENT_REDIRECT),
+      history::SOURCE_BROWSED);
+
+  // Ensure the typed count is still 1 but the visit count is 2.
+  id = backend_->db()->GetRowForURL(url2, &row);
+  ASSERT_TRUE(backend_->db()->GetVisitsForURL(id, &visits));
+  EXPECT_EQ(0, row.typed_count());
+  EXPECT_EQ(2, row.visit_count());
+}
+
 TEST_F(HistoryBackendTest, AddPageVisitSource) {
   ASSERT_TRUE(backend_.get());
 
   GURL url("http://www.google.com");
 
   // Clear all history.
   backend_->DeleteAllHistory();
 
   // Assume visiting the url from an externsion.
   backend_->AddPageVisit(
@@ skipping 2075 matching lines @@
   // Verify that the second term is no longer returned as result, and also check
   // at the low level that it is gone for good. The term corresponding to the
   // first URLRow should not be affected.
   EXPECT_EQ(1u, GetNumberOfMatchingSearchTerms(kTestKeywordId, term1));
   EXPECT_EQ(0u, GetNumberOfMatchingSearchTerms(kTestKeywordId, term2));
   EXPECT_TRUE(mem_backend_->db()->GetKeywordSearchTermRow(row1.id(), NULL));
   EXPECT_FALSE(mem_backend_->db()->GetKeywordSearchTermRow(row2.id(), NULL));
 }
 
 }  // namespace history