Don't treat back/forwards as typed transitions in history.

chrome/browser/history/history_backend_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/history_backend.h"
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
@@ skipping 852 matching lines @@
                              ui::PAGE_TRANSITION_KEYWORD_GENERATED,
                              history::SOURCE_BROWSED, false);
   backend_->AddPage(request);
 
   // A row should have been added for the url.
   URLRow row;
   URLID url_id = backend_->db()->GetRowForURL(url, &row);
   ASSERT_NE(0, url_id);
 
   // The typed count should be 1.
   ASSERT_EQ(1, row.typed_count());

[Peter Kasting, 2015/03/24 22:09:59]

Can you extend this test somewhere to verify that navigating back to this
doesn't bump the typed_count to 2, or else extend your new test to test the
KEYWORD_GENERATED type?

[Charlie Reis, 2015/03/27 17:03:14]

Done.

 
   // KEYWORD_GENERATED urls should not be added to the segment db.
   std::string segment_name = VisitSegmentDatabase::ComputeSegmentName(url);
   EXPECT_EQ(0, backend_->db()->GetSegmentNamed(segment_name));
 
   // One visit should be added.
   VisitVector visits;
   EXPECT_TRUE(backend_->db()->GetVisitsForURL(url_id, &visits));
   EXPECT_EQ(1U, visits.size());
 
@@ skipping 311 matching lines @@
 
   // Fetch the row information about stripped url from history db.
   VisitVector visits;
   URLID row_id = backend_->db_->GetRowForURL(stripped_url, NULL);
   backend_->db_->GetVisitsForURL(row_id, &visits);
 
   // Check if stripped url is stored in database.
   ASSERT_EQ(1U, visits.size());
 }
 
+TEST_F(HistoryBackendTest, AddPageVisitBackForward) {
+  ASSERT_TRUE(backend_.get());
+
+  GURL url("http://www.google.com");
+
+  // Clear all history.
+  backend_->DeleteAllHistory();
+
+  // Visit the url after typing it.
+  backend_->AddPageVisit(url, base::Time::Now(), 0,

[Peter Kasting, 2015/03/24 22:09:59]

I would explicitly check that typed and visit counts are both 1 here.

You may also want to add another test that typed redirects don't get an
incremented typed_count when visited directly or via back/forward.

[Charlie Reis, 2015/03/27 17:03:14]

Done.

+      ui::PAGE_TRANSITION_TYPED,
+      history::SOURCE_BROWSED);
+
+  // Visit the url again via back/forward.
+  backend_->AddPageVisit(url, base::Time::Now(), 0,
+      ui::PageTransitionFromInt(
+          ui::PAGE_TRANSITION_TYPED | ui::PAGE_TRANSITION_FORWARD_BACK),
+      history::SOURCE_BROWSED);
+
+  // Ensure the typed count is only 1 but the visit count is 2.
+  VisitVector visits;
+  URLRow row;
+  URLID id = backend_->db()->GetRowForURL(url, &row);
+  ASSERT_TRUE(backend_->db()->GetVisitsForURL(id, &visits));
+  EXPECT_EQ(1, row.typed_count());
+  EXPECT_EQ(2, row.visit_count());
+}
+
 TEST_F(HistoryBackendTest, AddPageVisitSource) {
   ASSERT_TRUE(backend_.get());
 
   GURL url("http://www.google.com");
 
   // Clear all history.
   backend_->DeleteAllHistory();
 
   // Assume visiting the url from an externsion.
   backend_->AddPageVisit(
@@ skipping 2075 matching lines @@
   // Verify that the second term is no longer returned as result, and also check
   // at the low level that it is gone for good. The term corresponding to the
   // first URLRow should not be affected.
   EXPECT_EQ(1u, GetNumberOfMatchingSearchTerms(kTestKeywordId, term1));
   EXPECT_EQ(0u, GetNumberOfMatchingSearchTerms(kTestKeywordId, term2));
   EXPECT_TRUE(mem_backend_->db()->GetKeywordSearchTermRow(row1.id(), NULL));
   EXPECT_FALSE(mem_backend_->db()->GetKeywordSearchTermRow(row2.id(), NULL));
 }
 
 }  // namespace history