Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm

Issue 1011943002: Mac: Clicking an omnibox decoration should not highlight the omnibox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert a change to the unit test AutocompleteTextFieldTest.LeftDecorationMouseDown. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
index 6c25cc82855b4c1f9dfe9e570a413e9aaf04c648..1675052ee5afb68320a7c636055740eb5976d02d 100644
--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
@@ -392,6 +392,17 @@ const CGFloat kAnimationDuration = 0.2;
DCHECK_EQ([self currentEditor], [[self window] firstResponder]);
return NO;
}
+
+ // If the event is a left-mouse click, and it lands on a decoration, then the
+ // event should not cause the text field to become first responder.
+ NSEvent* event = [NSApp currentEvent];
+ if ([event type] == NSLeftMouseDown) {
+ LocationBarDecoration* decoration =
+ [[self cell] decorationForEvent:event inRect:[self bounds] ofView:self];
+ if (decoration && decoration->AcceptsMousePress())
+ return NO;
+ }
+
return [super acceptsFirstResponder];
}
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698