Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 101193007: Add missing gyp exclude in https://codereview.chromium.org/108193005 (Closed)

Created:
7 years ago by pkotwicz
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
shrikant@ PTAL
7 years ago (2013-12-20 16:20:36 UTC) #1
pkotwicz
James, can you please take a look? I am unsure if shrikant@ is in today. ...
7 years ago (2013-12-20 18:24:33 UTC) #2
Shrikant Kelkar
On 2013/12/20 18:24:33, pkotwicz wrote: > James, can you please take a look? I am ...
7 years ago (2013-12-20 18:26:51 UTC) #3
James Cook
LGTM although I am unclear on how https://codereview.chromium.org/108193005/ compiles on Chrome OS. In particular, I ...
7 years ago (2013-12-20 18:47:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/101193007/1
7 years ago (2013-12-20 18:51:21 UTC) #5
pkotwicz
7 years ago (2013-12-20 19:34:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r242139 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698