Send AX focus changed events for modal dialog open/close

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 3392 matching lines @@
                 // Re-get the widget in case updating the layout changed things.
                 focusWidget = widgetForElement(*m_focusedElement);
             }
             if (focusWidget)
                 focusWidget->setFocus(true);
             else
                 view()->setFocus(true);
         }
     }
 
-    if (!focusChangeBlocked && m_focusedElement) {
+    if (m_focusedElement != oldFocusedElement) {

[dmazzoni, 2013/12/10 08:07:53]

Did you mean to get rid of the test for !focusChangeBlocked? Why?

[falken, 2013/12/10 12:19:57]

Hum, I remember needing to get rid of it (and thinking it makes sense to always
tell AT if focus changed), but upon re-testing it's OK to keep it in. Probably
it's best to leave it in then.

         // Create the AXObject cache in a focus change because Chromium relies on it.
         if (AXObjectCache* cache = axObjectCache())
-            cache->handleFocusedUIElementChanged(oldFocusedElement.get(), newFocusedElement.get());
+            cache->handleFocusedUIElementChanged(*this);
     }
 
     if (!focusChangeBlocked && page())
         page()->chrome().focusedNodeChanged(m_focusedElement.get());
 
 SetFocusedElementDone:
     updateStyleIfNeeded();
     if (Frame* frame = this->frame())
         frame->selection().didChangeFocus();
     return !focusChangeBlocked;
@@ skipping 1805 matching lines @@
 }
 
 FastTextAutosizer* Document::fastTextAutosizer()
 {
     if (!m_fastTextAutosizer && RuntimeEnabledFeatures::fastTextAutosizingEnabled())
         m_fastTextAutosizer = FastTextAutosizer::create(this);
     return m_fastTextAutosizer.get();
 }
 
 } // namespace WebCore