Add a role info dictionary to output.js to resolve role msgs.

chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Provides output services for ChromeVox.
  */
 
 goog.provide('Output');
 goog.provide('Output.EventType');
@@ skipping 59 matching lines @@
   this.speechProperties_ = {};
 };
 
 /**
  * Delimiter to use between output values.
  * @type {string}
  */
 Output.SPACE = ' ';
 
 /**
+ * Metadata about supported automation roles.
+ * @const {Object<string, {msgId: string, earcon: string}>}
+ */
+Output.ROLE_INFO = {
+  alert: {
+    msgId: 'aria_role_alert',
+    earcon: 'ALERT_NONMODAL',
+  },
+  button: {
+    msgId: 'tag_button',
+    earcon: 'BUTTON'
+  },
+  checkbox: {
+    msgId: 'input_type_checkbox'
+  },
+  heading: {
+    msgId: 'aria_role_heading',
+  },
+  link: {
+    msgId: 'tag_link',
+    earcon: 'LINK'
+  },
+  list: {
+    msgId: 'LIST_WITH_ITEMS'

[Peter Lundblad, 2015/03/17 10:34:09]

This message takes one parameter, how is that handled?

[Peter Lundblad, 2015/03/17 10:34:09]

nit: lower case.

+  },
+  listItem: {
+    msgId: 'ARIA_ROLE_LISTITEM',
+    earcon: 'list_item'
+  },
+  menuListOption: {
+    msgId: 'aria_role_menuitem'
+  },
+  popUpButton: {
+    msgId: 'tag_button'
+  },
+  radioButton: {
+    msgId: 'input_type_radio'
+  },
+  textBox: {
+    msgId: 'input_type_text',
+    earcon: 'EDITABLE_TEXT'
+  },
+  textField: {
+    msgId: 'input_type_text',
+    earcon: 'EDITABLE_TEXT'
+  }
+};
+
+/**
  * Rules specifying format of AutomationNodes for output.
  * @type {!Object<string, Object<string, Object<string, string>>>}
  */
 Output.RULES = {
   navigate: {
     'default': {
       speak: '$name $role $value',
       braille: ''
     },
     alert: {
       speak: '!doNotInterrupt ' +
           '@aria_role_alert $name $earcon(ALERT_NONMODAL) $descendants'
     },
-    button: {
-      speak: '$name $earcon(BUTTON, @tag_button)'
-    },
     checkBox: {
       speak: '$if($checked, @describe_checkbox_checked($name), ' +
           '@describe_checkbox_unchecked($name)) ' +
           '$if($checked, ' +
               '$earcon(CHECK_ON, @input_type_checkbox), ' +
               '$earcon(CHECK_OFF, @input_type_checkbox))'
     },
     dialog: {
       enter: '$name $role'
     },
@@ skipping 37 matching lines @@
           '$if($checked, ' +
               '$earcon(CHECK_ON, @input_type_radio), ' +
               '$earcon(CHECK_OFF, @input_type_radio))'
     },
     slider: {
       speak: '@describe_slider($value, $name)'
     },
     staticText: {
       speak: '$value'
     },
-    textBox: {
-      speak: '$name $value $earcon(EDITABLE_TEXT, @input_type_text)'
-    },
     tab: {
       speak: '@describe_tab($name)'
     },
-    textField: {
-      speak: '$name $value $earcon(EDITABLE_TEXT, @input_type_text) $protected'
-    },
     toolbar: {
       enter: '$name $role'
     },
     window: {
       enter: '$name',
       speak: '@describe_window($name) $earcon(OBJECT_OPEN)'
     }
   },
   menuStart: {
     'default': {
@@ skipping 248 matching lines @@
       // Process token based on prefix.
       var prefix = token[0];
       token = token.slice(1);
 
       if (opt_exclude[token])
         return;
 
       // All possible tokens based on prefix.
       if (prefix == '$') {
         options.annotation = token;
-        if (token == 'role') {
-          // Non-localized role and state obtained by default.
-          this.addToSpannable_(buff, node.role, options);
-        } else if (token == 'value') {
+        if (token == 'value') {
           var text = node.attributes.value;
           if (text) {
             var offset = buff.getLength();
             if (node.attributes.textSelStart !== undefined) {
               options.annotation = new Output.SelectionSpan(
                   node.attributes.textSelStart,
                   node.attributes.textSelEnd);
             }
           } else if (node.role == chrome.automation.RoleType.staticText) {
             // TODO(dtseng): Remove once Blink treats staticText values as
@@ skipping 29 matching lines @@
               node, Dir.FORWARD, AutomationPredicate.leaf);
           var rightmost = AutomationUtil.findNodePre(
               node, Dir.BACKWARD, AutomationPredicate.leaf);
           if (!leftmost || !rightmost)
             return;
 
           var subrange = new cursors.Range(
               new cursors.Cursor(leftmost, 0),
               new cursors.Cursor(rightmost, 0));
           this.range_(subrange, null, 'navigate', buff);
+        } else if (token == 'role') {
+          var msgId = node.role;

[Peter Lundblad, 2015/03/17 10:34:09]

If we want this, then the msgIds should be qualified, e.g.
  msgId = 'role_' + node.role;
to not polute the namespace with role names.

+          var earconId = null;
+          var info = Output.ROLE_INFO[node.role];
+          if (info) {
+            msgId = info.msgId;
+            earconId = info.earcon;
+          }
+          if (earconId) {
+            options.annotation = new Output.Action(function() {
+              cvox.ChromeVox.earcons.playEarcon(
+                  cvox.AbstractEarcons[earconId]);
+            });
+          }
+          this.addToSpannable_(

[Peter Lundblad, 2015/03/17 10:34:09]

Should the msgId be suffixed by _brl if such a message exists to get the
correct role for braille?

+              buff, cvox.ChromeVox.msgs.getMsg(msgId), options);
         } else if (node.attributes[token]) {
           this.addToSpannable_(buff, node.attributes[token], options);
         } else if (node.state[token]) {
           this.addToSpannable_(buff, token, options);
         } else if (tree.firstChild) {
           // Custom functions.
           if (token == 'if') {
             var cond = tree.firstChild;
             var attrib = cond.value.slice(1);
             if (node.attributes[attrib] || node.state[attrib])
@@ skipping 238 matching lines @@
     }
 
     if (currentNode != root)
       throw 'Unbalanced parenthesis.';
 
     return root;
   }
 };
 
 });  // goog.scope