[Telemetry] Modify ValueCanBeAddedPredicate so it cannot filter out skip & failure value.

[Telemetry] Modify ValueCanBeAddedPredicate so it cannot filter out skip & failure value.

In crbug.com/466196, the gpu_times benchmark unintentionally filters out skip
value, and made it hard to figure out what went wrong. When people do whitelist
filtering, most of them will also make the mistake of filtering our skip &
failure values unintentionally. I also think that these values shouldn't be
filtered out in any situation.

BUG=466196
Committed: https://crrev.com/17df9bb109026cbe8e9b8fc4dbd38235d1f2fad4
Cr-Commit-Position: refs/heads/master@{#320871}

[nednguyen, 2015-03-16 21:26:37]

nednguyen@google.com changed reviewers:
+ eakuefner@chromium.org

[eakuefner, 2015-03-16 23:23:07]

eakuefner@chromium.org changed reviewers:
+ aiolos@chromium.org, dtu@chromium.org

[eakuefner, 2015-03-16 23:23:34]

+aiolos, dtu for committer stamp

lgtm (fixed CL title for commit log)

[aiolos (Not reviewing), 2015-03-17 00:08:12]

lgtm

https://codereview.chromium.org/1011893002/diff/1/tools/telemetry/telemetry/r...
File tools/telemetry/telemetry/results/page_test_results_unittest.py (right):

https://codereview.chromium.org/1011893002/diff/1/tools/telemetry/telemetry/r...
tools/telemetry/telemetry/results/page_test_results_unittest.py:316: # Although
predicate says only accept value with named 'a', failure value is
nit: minor english usage.

"with" is a preposition that generally indicates a relationship between two
nouns/noun phrases, but "named 'a'" is a participle phrase.

Possible change:
# Although the predicate says to only accept values named 'a', the failure value
is added anyway.

[nednguyen, 2015-03-17 03:17:35]

https://codereview.chromium.org/1011893002/diff/1/tools/telemetry/telemetry/r...
File tools/telemetry/telemetry/results/page_test_results_unittest.py (right):

https://codereview.chromium.org/1011893002/diff/1/tools/telemetry/telemetry/r...
tools/telemetry/telemetry/results/page_test_results_unittest.py:316: # Although
predicate says only accept value with named 'a', failure value is
On 2015/03/17 00:08:11, aiolos wrote:
> nit: minor english usage.
> 
> "with" is a preposition that generally indicates a relationship between two
> nouns/noun phrases, but "named 'a'" is a participle phrase.
> 
> Possible change:
> # Although the predicate says to only accept values named 'a', the failure
value
> is added anyway.

Done. Thanks for your explanation, Kari!

[nednguyen, 2015-03-17 03:17:38]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-03-17 03:17:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, aiolos@chromium.org
Link to the patchset: https://codereview.chromium.org/1011893002/#ps20001
(title: "Address Kari's comment")

[commit-bot: I haz the power, 2015-03-17 03:17:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1011893002/20001

[commit-bot: I haz the power, 2015-03-17 05:42:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-17 05:42:38]

Patchset 2 (id:??) landed as
https://crrev.com/17df9bb109026cbe8e9b8fc4dbd38235d1f2fad4
Cr-Commit-Position: refs/heads/master@{#320871}