Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 1011873002: Do not re-add alternate protocol in SetBrokenAlternateProtocol. (Closed)

Created:
3 years, 7 months ago by Bence
Modified:
3 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not re-add alternate protocol in SetBrokenAlternateProtocol. Do not re-add alternate protocol from canonical host to origin in HttpServerPropertiesImpl::SetBrokenAlternateProtocol(), because brokenness is recorded independently of the alternate protocol mapping. I have overlooked this detail in https://crrev.com/997953003/diff/80001/net/http/http_server_properties_impl.cc. BUG=392576 Committed: https://crrev.com/11ba7b9dc237469101b0f188921a377dc2506179 Cr-Commit-Position: refs/heads/master@{#320897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M net/http/http_server_properties_impl.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan, PTAL. Thanks.
3 years, 7 months ago (2015-03-16 21:12:53 UTC) #2
Ryan Hamilton
lgtm
3 years, 7 months ago (2015-03-17 03:24:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011873002/1
3 years, 7 months ago (2015-03-17 11:37:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 7 months ago (2015-03-17 11:41:12 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2015-03-17 11:41:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11ba7b9dc237469101b0f188921a377dc2506179
Cr-Commit-Position: refs/heads/master@{#320897}

Powered by Google App Engine
This is Rietveld 408576698