Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1011823005: Allow browser compositor control over frames pending with surfaceless rendering on freon. (Closed)

Created:
5 years, 9 months ago by alexst (slow to review)
Modified:
5 years, 9 months ago
Reviewers:
brianderson, piman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This adds missing plumbing to single_thread_proxy to forward max pending frames from the surface to the compositor, but keeps max pending value the same for the time being. Currently the call to SetMaxSwapsPendingOnImplThread in layer_tree_host_impl.cc gets dropped on the floor for ChromeOS. Previously, driver implementation of eglSwapBuffers returned before page flip actually happened, allowing the browser compositor to start scheduling the next frame while the front buffer was still shown. With switch to freon, SwapBuffersACK is sent on page flip, affecting scheduler timing. This enables the browser compositor to queue up a new frame earlier when necessary. BUG=465599 Committed: https://crrev.com/346f30ca47612c605de5ae38ac892a6b55554198 Cr-Commit-Position: refs/heads/master@{#322148}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
alexst (slow to review)
5 years, 9 months ago (2015-03-24 14:52:04 UTC) #3
brianderson
lgtm
5 years, 9 months ago (2015-03-25 01:03:05 UTC) #4
piman
lgtm https://codereview.chromium.org/1011823005/diff/20001/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc File content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc (right): https://codereview.chromium.org/1011823005/diff/20001/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc#newcode33 content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc:33: capabilities_.max_frames_pending = 1; nit: that's already done by ...
5 years, 9 months ago (2015-03-25 01:39:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011823005/40001
5 years, 9 months ago (2015-03-25 02:23:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/1181)
5 years, 9 months ago (2015-03-25 04:50:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011823005/40001
5 years, 9 months ago (2015-03-25 12:39:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-25 13:24:15 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 13:24:57 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/346f30ca47612c605de5ae38ac892a6b55554198
Cr-Commit-Position: refs/heads/master@{#322148}

Powered by Google App Engine
This is Rietveld 408576698