[es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions)

test/webkit/preventExtensions.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
 // are met:
 // 1.  Redistributions of source code must retain the above copyright
 //     notice, this list of conditions and the following disclaimer.
 // 2.  Redistributions in binary form must reproduce the above copyright
 //     notice, this list of conditions and the following disclaimer in the
@@ skipping 74 matching lines @@
 shouldBeTrue("(new frozen).prototypeExists");
 
 shouldBe('test(obj())', '"(b:4)(c:3)E"'); // extensible, can delete a, can modify b, and can add c
 shouldBe('test(preventExtensions(obj()))', '"(b:4)"'); // <nothing>, can delete a, can modify b, and CANNOT add c
 shouldBe('test(seal(obj()))', '"(a:1)(b:4)S"'); // sealed, CANNOT delete a, can modify b, and CANNOT add c
 shouldBe('test(freeze(obj()))', '"(a:1)(b:2)SF"'); // sealed and frozen, CANNOT delete a, CANNOT modify b, and CANNOT add c
 
 // check that we can preventExtensions on a host function.
 shouldBe('Object.preventExtensions(Math.sin)', 'Math.sin');
 
-shouldThrow('var o = {}; Object.preventExtensions(o); o.__proto__ = { newProp: "Should not see this" }; o.newProp;');
-shouldThrow('"use strict"; var o = {}; Object.preventExtensions(o); o.__proto__ = { newProp: "Should not see this" }; o.newProp;');
+shouldBe('var o = {}; Object.preventExtensions(o); o.__proto__ = { newProp: "Should not see this" }; o.newProp;');

[arv (Not doing code reviews), 2015/03/19 19:38:08]

This looks strange. shouldBe takes two strings that are evaluated and compared.

[caitp (gmail), 2015/03/19 20:16:15]

Looks like in this case, it should throw
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-set-object.prototyp...
--- but for other properties it shouldn't.

+shouldBe('"use strict"; var o = {}; Object.preventExtensions(o); o.__proto__ = { newProp: "Should not see this" }; o.newProp;');

[arv (Not doing code reviews), 2015/03/19 19:38:08]

This should still throw, shouldn't it?

[caitp (gmail), 2015/03/19 19:42:10]

Yeah. I passed make check, but I guess the WebKit tests aren't run that way.
I'll you're both of these tonight

 
 // check that we can still access static properties on an object after calling preventExtensions.
 shouldBe('Object.preventExtensions(Math); Math.sqrt(4)', '2');
 
 // Should not be able to add properties to a preventExtensions array.
 shouldBeUndefined('var arr = Object.preventExtensions([]); arr[0] = 42; arr[0]');
 shouldBe('var arr = Object.preventExtensions([]); arr[0] = 42; arr.length', '0');
 // In strict mode, this throws.
 shouldThrow('"use strict"; var arr = Object.preventExtensions([]); arr[0] = 42; arr[0]');
 
@@ skipping 41 matching lines @@
     Object.freeze(x);
     return Object.isFrozen(x);
 }
 shouldBeTrue('preventExtensionsFreezeIsFrozen(function foo(){})')
 shouldBeTrue('preventExtensionsFreezeIsFrozen(function foo(){ "use strict"; })')
 shouldBeTrue('preventExtensionsFreezeIsFrozen([0,1,2])')
 shouldBeTrue('preventExtensionsFreezeIsFrozen((function(){ return arguments; })(0,1,2))')
 
 shouldBeFalse('Object.getOwnPropertyDescriptor(freeze({0:0}), 0).configurable');
 shouldBeFalse('Object.getOwnPropertyDescriptor(freeze({10000001:0}), 10000001).configurable');