Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1011823002: Fix some GN component build issues. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some GN component build issues. This fixes some files not compiling with the proper flags for component mode. The device_event_log target in GN is a source set in GN and a component in GYP. This difference was causing some errors. I changed this to be a static library in GYP. It only has 2 files in it so making a whole shared library for this target seems wasteful. Committed: https://crrev.com/8f2fd17e33f365c1a73dd25aa33a3a2877d0c1d5 Cr-Commit-Position: refs/heads/master@{#320805}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -73 lines) Patch
M components/device_event_log.gypi View 1 2 chunks +1 line, -4 lines 0 comments Download
M components/device_event_log/device_event_log.h View 1 5 chunks +17 lines, -18 lines 0 comments Download
D components/device_event_log/device_event_log_export.h View 1 1 chunk +0 lines, -29 lines 0 comments Download
M components/device_event_log/device_event_log_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M gpu/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 2 3 chunks +11 lines, -8 lines 0 comments Download
M gpu/command_buffer/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M gpu/config/BUILD.gn View 2 chunks +6 lines, -5 lines 0 comments Download
M gpu/ipc/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
5 years, 9 months ago (2015-03-16 19:43:42 UTC) #2
scottmg
lgtm
5 years, 9 months ago (2015-03-16 20:33:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011823002/40001
5 years, 9 months ago (2015-03-16 21:18:24 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-16 22:14:24 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 22:15:19 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f2fd17e33f365c1a73dd25aa33a3a2877d0c1d5
Cr-Commit-Position: refs/heads/master@{#320805}

Powered by Google App Engine
This is Rietveld 408576698