Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1011813006: Make availability of hotword hardware known to hotword component extension. (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
Reviewers:
kcarattini, benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make availability of hotword hardware known to hotword component extension. BUG=465971 Committed: https://crrev.com/c15c2b91c7864c402bae642a6fd329641283e9bd Cr-Commit-Position: refs/heads/master@{#321525}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename field. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -12 lines) Patch
M chrome/browser/extensions/api/hotword_private/hotword_private_api.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/hotword/constants.js View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/hotword/nacl_manager.js View 3 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/resources/hotword/state_manager.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/search/hotword_service.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/search/hotword_service_factory.cc View 1 2 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/common/extensions/api/hotword_private.idl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Anand Mistry (off Chromium)
5 years, 9 months ago (2015-03-17 00:20:53 UTC) #2
kcarattini
https://codereview.chromium.org/1011813006/diff/1/chrome/common/extensions/api/hotword_private.idl File chrome/common/extensions/api/hotword_private.idl (right): https://codereview.chromium.org/1011813006/diff/1/chrome/common/extensions/api/hotword_private.idl#newcode44 chrome/common/extensions/api/hotword_private.idl:44: boolean hotwordStreamAvailable; Why not call this hotwordHardwareAvailable? That's what ...
5 years, 9 months ago (2015-03-17 00:47:15 UTC) #3
kcarattini
https://codereview.chromium.org/1011813006/diff/1/chrome/browser/search/hotword_service.h File chrome/browser/search/hotword_service.h (right): https://codereview.chromium.org/1011813006/diff/1/chrome/browser/search/hotword_service.h#newcode67 chrome/browser/search/hotword_service.h:67: static bool IsHotwordHardwareAvailable(); Why is this is HotwordService and ...
5 years, 9 months ago (2015-03-17 01:38:41 UTC) #4
Anand Mistry (off Chromium)
https://codereview.chromium.org/1011813006/diff/1/chrome/browser/search/hotword_service.h File chrome/browser/search/hotword_service.h (right): https://codereview.chromium.org/1011813006/diff/1/chrome/browser/search/hotword_service.h#newcode67 chrome/browser/search/hotword_service.h:67: static bool IsHotwordHardwareAvailable(); On 2015/03/17 01:38:41, kcarattini wrote: > ...
5 years, 9 months ago (2015-03-17 02:54:48 UTC) #5
kcarattini
lgtm
5 years, 9 months ago (2015-03-17 22:45:15 UTC) #6
Anand Mistry (off Chromium)
jhawkins@chromium.org: For OWNERS.
5 years, 9 months ago (2015-03-18 00:30:37 UTC) #8
Anand Mistry (off Chromium)
Ben: For extensions OWNERS.
5 years, 9 months ago (2015-03-20 03:25:15 UTC) #10
benwells
lgtm
5 years, 9 months ago (2015-03-20 04:07:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011813006/20001
5 years, 9 months ago (2015-03-20 04:11:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/7195)
5 years, 9 months ago (2015-03-20 04:14:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011813006/40001
5 years, 9 months ago (2015-03-20 04:56:06 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-20 06:24:33 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 06:25:41 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c15c2b91c7864c402bae642a6fd329641283e9bd
Cr-Commit-Position: refs/heads/master@{#321525}

Powered by Google App Engine
This is Rietveld 408576698