Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Issue 1011753003: Reenable CvoxBrailleIntegrationTests that were previously flaky. (Closed)

Created:
5 years, 9 months ago by Peter Lundblad
Modified:
5 years, 9 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable CvoxBrailleIntegrationTests that were previously flaky. BUG=462294 Committed: https://crrev.com/69f69ee169b1a34f749186524ac5cb65af90ac7b Cr-Commit-Position: refs/heads/master@{#320733}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Listen for focus event instead of polling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -57 lines) Patch
M chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs View 1 5 chunks +81 lines, -57 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Peter Lundblad
5 years, 9 months ago (2015-03-16 14:10:45 UTC) #2
dmazzoni
https://codereview.chromium.org/1011753003/diff/1/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs File chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs (right): https://codereview.chromium.org/1011753003/diff/1/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs#newcode85 chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs:85: window.setTimeout(checkFocus, 100); Rather than setTimeout, use a focus event ...
5 years, 9 months ago (2015-03-16 15:07:16 UTC) #4
Peter Lundblad
PTAL dmazzoni@chromium.org writes: > > https://codereview.chromium.org/1011753003/diff/1/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs > File > chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs > (right): > > https://codereview.chromium.org/1011753003/diff/1/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs#newcode85 ...
5 years, 9 months ago (2015-03-16 15:45:52 UTC) #5
dmazzoni
lgtm I'm pretty sure window.onfocus and document.hasFocus() are the same so this looks right to ...
5 years, 9 months ago (2015-03-16 15:49:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011753003/20001
5 years, 9 months ago (2015-03-16 15:50:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 16:10:19 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 16:11:19 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69f69ee169b1a34f749186524ac5cb65af90ac7b
Cr-Commit-Position: refs/heads/master@{#320733}

Powered by Google App Engine
This is Rietveld 408576698