Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: chrome/tools/build/win/syzygy/instrument.py

Issue 1011743003: Roll Syzygy deps to 0.8.6.3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update version hash. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/win/syzygy/instrument.py
diff --git a/chrome/tools/build/win/syzygy/instrument.py b/chrome/tools/build/win/syzygy/instrument.py
index 4df7d30b3ec9c814cf01aa5e0b87298eab8f0f4d..a8a26e0b67018f4a97d8a7e03fa18556d311a6e4 100755
--- a/chrome/tools/build/win/syzygy/instrument.py
+++ b/chrome/tools/build/win/syzygy/instrument.py
@@ -75,6 +75,10 @@ def _InstrumentBinary(syzygy_dir, mode, executable, symbol, dst_dir,
if mode == "asan":
cmd.append('--no-augment-pdb')
+ # Disable some of the new SysyASAN features. We're seeing an increase in
+ # crash rates and are wondering if they are to blame.
+ cmd.append(
+ '--asan-rtl-options="--disable_ctmalloc --disable_large_block_heap"')
# If any filters were specified then pass them on to the instrumenter.
if filter_file:
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698