Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1011743002: Revert of Revert of Per-renderer WebSocket throttling (Closed)

Created:
5 years, 9 months ago by hiroshige
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Per-renderer WebSocket throttling (patchset #1 id:1 of https://codereview.chromium.org/1009303002/) Reason for revert: The breakage still persists https://crbug.com/467471 after the original CL was reverted. Original issue's description: > Revert of Per-renderer WebSocket throttling (patchset #13 id:300001 of https://codereview.chromium.org/972963002/) > > Reason for revert: > Suspected to have caused WebSocket breakage. > Failure seen on apprtc.appspot.com and in browser_tests. Run the manual MANUAL_WorksWithAppRTC test for repro. > > See https://code.google.com/p/chromium/issues/detail?id=467471&thanks=467471&ts=1426498439 for details. > > Original issue's description: > > Per-renderer WebSocket throttling > > > > Design Doc: > > https://docs.google.com/document/d/1aw2oN5PKfk-1gLnBrlv1OwLA8K3-ykM2ckwX2lubTg4/edit?usp=sharing > > > > BUG=459377 > > > > Committed: https://crrev.com/58d344316cf2b2cc110619c0fea4979ef143b3a9 > > Cr-Commit-Position: refs/heads/master@{#320074} > > TBR=ricea@chromium.org,hiroshige@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=459377 > > Committed: https://crrev.com/3464a08a0c157c57ea02881687f10058303de8ea > Cr-Commit-Position: refs/heads/master@{#320705} TBR=ricea@chromium.org,henrika@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459377 Committed: https://crrev.com/926c6015f4e4bb5347569c41219dd5835cd702cd Cr-Commit-Position: refs/heads/master@{#320715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -37 lines) Patch
M content/browser/renderer_host/websocket_dispatcher_host.h View 6 chunks +48 lines, -13 lines 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host.cc View 7 chunks +96 lines, -6 lines 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host_unittest.cc View 6 chunks +208 lines, -13 lines 0 comments Download
M content/browser/renderer_host/websocket_host.h View 5 chunks +26 lines, -1 line 0 comments Download
M content/browser/renderer_host/websocket_host.cc View 4 chunks +60 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hiroshige
Created Revert of Revert of Per-renderer WebSocket throttling
5 years, 9 months ago (2015-03-16 12:55:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011743002/1
5 years, 9 months ago (2015-03-16 12:55:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 12:56:34 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 12:57:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/926c6015f4e4bb5347569c41219dd5835cd702cd
Cr-Commit-Position: refs/heads/master@{#320715}

Powered by Google App Engine
This is Rietveld 408576698