Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1011703003: Serializer: Cache FlagList::Hash result. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: Cache FlagList::Hash result. R=vogelheim@chromium.org Committed: https://crrev.com/d74f5c6f09704a86ca1b87d6acf8cb6c1d09ba24 Cr-Commit-Position: refs/heads/master@{#27234}

Patch Set 1 #

Patch Set 2 : fix test case #

Patch Set 3 : fix test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M src/flags.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/flags.cc View 1 2 2 chunks +15 lines, -8 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Yang
5 years, 9 months ago (2015-03-16 13:36:20 UTC) #1
vogelheim
lgtm
5 years, 9 months ago (2015-03-16 14:53:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011703003/1
5 years, 9 months ago (2015-03-16 14:55:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/3864)
5 years, 9 months ago (2015-03-16 15:22:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011703003/20001
5 years, 9 months ago (2015-03-17 09:30:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011703003/40001
5 years, 9 months ago (2015-03-17 10:27:49 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-17 11:04:16 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 11:04:38 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d74f5c6f09704a86ca1b87d6acf8cb6c1d09ba24
Cr-Commit-Position: refs/heads/master@{#27234}

Powered by Google App Engine
This is Rietveld 408576698