stop using deprecated SkPaint::FilterLevel

stop using deprecated SkPaint::FilterLevel

needs https://codereview.chromium.org/1013803002/ to land and roll into chrome.

BUG=

Committed: https://crrev.com/55801f247a04f03828e72619cb3d45d694d8d025
Cr-Commit-Position: refs/heads/master@{#320909}

[reed1, 2015-03-16 18:11:49]

reed@google.com changed reviewers:
+ danakj@chromium.org, ddorwin@chromium.org, sadrul@chromium.org

[reed1, 2015-03-16 18:11:50]

pure api refactoring. need OWNERS for cc, content, media, ui

[danakj, 2015-03-16 18:16:28]

cc LGTM

https://codereview.chromium.org/1011683006/diff/1/cc/output/renderer_pixeltes...
File cc/output/renderer_pixeltest.cc (right):

https://codereview.chromium.org/1011683006/diff/1/cc/output/renderer_pixeltes...
cc/output/renderer_pixeltest.cc:2317:
paint.setFilterQuality(kLow_SkFilterQuality);
API driveby comment, it would be nice to scope this constant somehow so one
knows where to look for it. Either in a class/namespace (like SkPaint::) or with
a prefix.

[ddorwin, 2015-03-16 18:18:00]

*/media/ LGTM

[reed1, 2015-03-16 18:18:25]

On 2015/03/16 18:16:28, danakj wrote:
> cc LGTM
> 
>
https://codereview.chromium.org/1011683006/diff/1/cc/output/renderer_pixeltes...
> File cc/output/renderer_pixeltest.cc (right):
> 
>
https://codereview.chromium.org/1011683006/diff/1/cc/output/renderer_pixeltes...
> cc/output/renderer_pixeltest.cc:2317:
> paint.setFilterQuality(kLow_SkFilterQuality);
> API driveby comment, it would be nice to scope this constant somehow so one
> knows where to look for it. Either in a class/namespace (like SkPaint::) or
with
> a prefix.

Skia accomplishes this with a suffix : SkFilterQuality is the enum type (and the
filename).

[danakj, 2015-03-16 18:19:37]

On Mon, Mar 16, 2015 at 11:18 AM, reed via cc-bugs <cc-bugs@chromium.org>
wrote:

> On 2015/03/16 18:16:28, danakj wrote:
>
>> cc LGTM
>>
>
>
> https://codereview.chromium.org/1011683006/diff/1/cc/
> output/renderer_pixeltest.cc
>
>> File cc/output/renderer_pixeltest.cc (right):
>>
>
>
> https://codereview.chromium.org/1011683006/diff/1/cc/
> output/renderer_pixeltest.cc#newcode2317
>
>> cc/output/renderer_pixeltest.cc:2317:
>> paint.setFilterQuality(kLow_SkFilterQuality);
>> API driveby comment, it would be nice to scope this constant somehow so
>> one
>> knows where to look for it. Either in a class/namespace (like SkPaint::)
>> or
>>
> with
>
>> a prefix.
>>
>
> Skia accomplishes this with a suffix : SkFilterQuality is the enum type
> (and the
> filename).
>

Ah, k thanks for the tip!


>
> https://codereview.chromium.org/1011683006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sadrul, 2015-03-16 18:39:15]

lgtm

[reed2, 2015-03-17 11:19:28]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2015-03-17 11:19:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1011683006/1

[commit-bot: I haz the power, 2015-03-17 13:16:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-17 13:17:02]

Patchset 1 (id:??) landed as
https://crrev.com/55801f247a04f03828e72619cb3d45d694d8d025
Cr-Commit-Position: refs/heads/master@{#320909}