chrome/browser/sync/glue/sync_backend_registrar_unittest.cc - Issue 1011683002: Lazily initialize MessageLoop for faster thread startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/sync_backend_registrar_unittest.cc

Issue 1011683002: Lazily initialize MessageLoop for faster thread startup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: weak ptr Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/thread_watcher_unittest.cc ('k') | content/browser/browser_thread_impl.cc » ('j') | net/android/network_change_notifier_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/sync_backend_registrar_unittest.cc

diff --git a/chrome/browser/sync/glue/sync_backend_registrar_unittest.cc b/chrome/browser/sync/glue/sync_backend_registrar_unittest.cc

index 3db65e9aa8506800906545295e371b71596ff562..75a55b5ae56585aa9cf7c72e809960e622e3421d 100644

--- a/chrome/browser/sync/glue/sync_backend_registrar_unittest.cc

+++ b/chrome/browser/sync/glue/sync_backend_registrar_unittest.cc

@@ -336,6 +336,9 @@ TEST_F(SyncBackendRegistrarShutdownTest, BlockingShutdown) {

base::Bind(&SyncBackendRegistrar::Shutdown,

base::Unretained(registrar.release())));

+ // Make sure the thread starts running.

+ sync_thread->WaitUntilThreadStartedForTesting();

// The test verifies that the sync thread doesn't block because

// of the blocked DB thread and can finish the shutdown.

sync_thread->message_loop()->RunUntilIdle();