Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: base/threading/thread_unittest.cc

Issue 1011683002: Lazily initialize MessageLoop for faster thread startup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/threading/thread_id_name_manager_unittest.cc ('k') | chrome/browser/io_thread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/threading/thread.h" 5 #include "base/threading/thread.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 EXPECT_FALSE(a.message_loop()); 187 EXPECT_FALSE(a.message_loop());
188 EXPECT_FALSE(a.IsRunning()); 188 EXPECT_FALSE(a.IsRunning());
189 } 189 }
190 190
191 TEST_F(ThreadTest, ThreadName) { 191 TEST_F(ThreadTest, ThreadName) {
192 Thread a("ThreadName"); 192 Thread a("ThreadName");
193 EXPECT_TRUE(a.Start()); 193 EXPECT_TRUE(a.Start());
194 EXPECT_EQ("ThreadName", a.thread_name()); 194 EXPECT_EQ("ThreadName", a.thread_name());
195 } 195 }
196 196
197 // Make sure we can't use a thread between Start() and Init(). 197 // Make sure Init() is called after Start() and before
198 // WaitUntilThreadInitialized() returns.
198 TEST_F(ThreadTest, SleepInsideInit) { 199 TEST_F(ThreadTest, SleepInsideInit) {
199 SleepInsideInitThread t; 200 SleepInsideInitThread t;
200 EXPECT_FALSE(t.InitCalled()); 201 EXPECT_FALSE(t.InitCalled());
201 t.Start(); 202 t.StartAndWaitForTesting();
202 EXPECT_TRUE(t.InitCalled()); 203 EXPECT_TRUE(t.InitCalled());
203 } 204 }
204 205
205 // Make sure that the destruction sequence is: 206 // Make sure that the destruction sequence is:
206 // 207 //
207 // (1) Thread::CleanUp() 208 // (1) Thread::CleanUp()
208 // (2) MessageLoop::~MessageLoop() 209 // (2) MessageLoop::~MessageLoop()
209 // MessageLoop::DestructionObservers called. 210 // MessageLoop::DestructionObservers called.
210 TEST_F(ThreadTest, CleanUp) { 211 TEST_F(ThreadTest, CleanUp) {
211 EventList captured_events; 212 EventList captured_events;
(...skipping 14 matching lines...) Expand all
226 227
227 // Upon leaving this scope, the thread is deleted. 228 // Upon leaving this scope, the thread is deleted.
228 } 229 }
229 230
230 // Check the order of events during shutdown. 231 // Check the order of events during shutdown.
231 ASSERT_EQ(static_cast<size_t>(THREAD_NUM_EVENTS), captured_events.size()); 232 ASSERT_EQ(static_cast<size_t>(THREAD_NUM_EVENTS), captured_events.size());
232 EXPECT_EQ(THREAD_EVENT_INIT, captured_events[0]); 233 EXPECT_EQ(THREAD_EVENT_INIT, captured_events[0]);
233 EXPECT_EQ(THREAD_EVENT_CLEANUP, captured_events[1]); 234 EXPECT_EQ(THREAD_EVENT_CLEANUP, captured_events[1]);
234 EXPECT_EQ(THREAD_EVENT_MESSAGE_LOOP_DESTROYED, captured_events[2]); 235 EXPECT_EQ(THREAD_EVENT_MESSAGE_LOOP_DESTROYED, captured_events[2]);
235 } 236 }
OLDNEW
« no previous file with comments | « base/threading/thread_id_name_manager_unittest.cc ('k') | chrome/browser/io_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698