Lazily initialize MessageLoop for faster thread startup

base/message_loop/message_loop_proxy_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_MESSAGE_LOOP_MESSAGE_LOOP_PROXY_IMPL_H_
 #define BASE_MESSAGE_LOOP_MESSAGE_LOOP_PROXY_IMPL_H_
 
 #include "base/base_export.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/pending_task.h"
 #include "base/threading/platform_thread.h"
 
 namespace base {
 namespace internal {
 
 class IncomingTaskQueue;
 
 // A stock implementation of MessageLoopProxy that is created and managed by a
 // MessageLoop. For now a MessageLoopProxyImpl can only be created as part of a
 // MessageLoop.
 class BASE_EXPORT MessageLoopProxyImpl : public MessageLoopProxy {
  public:
-  explicit MessageLoopProxyImpl(
+  static MessageLoopProxyImpl* Create(

[rvargas (doing something else), 2015/03/26 02:19:27]

return scoped ptr

[kinuko, 2015/04/13 02:02:59]

Removed this ctor.

+      scoped_refptr<IncomingTaskQueue> incoming_queue);
+
+  // Creates a proxy for lazy initialization. This type of MessageLoopProxy
+  // is intended to be created for the message loop that is to be initialized
+  // lazily (i.e. created by CreateForLazyInit()).  See the comment at
+  // MessageLoop::CreateForLazyInit() for more details.
+  static MessageLoopProxyImpl* CreateForLazyInit(

[rvargas (doing something else), 2015/03/26 02:19:27]

nit: Make this the default (Create) and hint that the other method is the
uncommon one.

[kinuko, 2015/04/13 02:02:59]

Done.

       scoped_refptr<IncomingTaskQueue> incoming_queue);
 
   // MessageLoopProxy implementation
   bool PostDelayedTask(const tracked_objects::Location& from_here,
                        const base::Closure& task,
                        base::TimeDelta delay) override;
   bool PostNonNestableDelayedTask(const tracked_objects::Location& from_here,
                                   const base::Closure& task,
                                   base::TimeDelta delay) override;
   bool RunsTasksOnCurrentThread() const override;
 
+  // Initialize this message loop proxy on the current thread.
+  // It is not valid to call this unless this proxy is created by
+  // CreateForLazyInit().
+  void LazyInit();

[rvargas (doing something else), 2015/03/26 02:19:27]

Init() ?

[kinuko, 2015/04/13 02:02:59]

Done.

+
  private:
   friend class RefCountedThreadSafe<MessageLoopProxyImpl>;
+  MessageLoopProxyImpl(scoped_refptr<IncomingTaskQueue> incoming_queue,
+                       bool lazy_init);
   ~MessageLoopProxyImpl() override;
 
   // THe incoming queue receiving all posted tasks.
   scoped_refptr<IncomingTaskQueue> incoming_queue_;
 
   // ID of the thread |this| was created on.
   PlatformThreadId valid_thread_id_;
 
   DISALLOW_COPY_AND_ASSIGN(MessageLoopProxyImpl);
 };
 
 }  // namespace internal
 }  // namespace base
 
 #endif  // BASE_MESSAGE_LOOP_MESSAGE_LOOP_PROXY_IMPL_H_