Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1011663002: [Files.app] Add tests of opening Gallery from Files.app (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app] Add tests of opening Gallery from Files.app BUG=465575 TEST=browser_test passes Committed: https://crrev.com/9b70272ba5c7e6829dcca8160637a7eb803ce1c2 Cr-Commit-Position: refs/heads/master@{#320866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -1 line) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/background.js View 1 chunk +9 lines, -0 lines 0 comments Download
A ui/file_manager/integration_tests/file_manager/open_image_files.js View 1 chunk +89 lines, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager_test_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/integration_tests/test_util.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@hirono, PTAL. Thanks.
5 years, 9 months ago (2015-03-16 13:07:00 UTC) #2
hirono
lgtm, thanks!
5 years, 9 months ago (2015-03-17 00:49:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011663002/1
5 years, 9 months ago (2015-03-17 04:49:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 04:51:58 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 04:53:04 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9b70272ba5c7e6829dcca8160637a7eb803ce1c2
Cr-Commit-Position: refs/heads/master@{#320866}

Powered by Google App Engine
This is Rietveld 408576698