Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1011653004: Fix android_run_skia script to allow for larger blacklist (Closed)

Created:
5 years, 9 months ago by msarett
Modified:
5 years, 9 months ago
Reviewers:
djsollen, scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix android_run_skia script to allow for larger blacklist BUG=skia: Committed: https://skia.googlesource.com/skia/+/114912d4b9dec67b02223ffa57ffab686442e332

Patch Set 1 : Fix android_run_skia script to allow for larger blacklist #

Patch Set 2 : Adding dm_flags.json #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+469 lines, -4 lines) Patch
M platform_tools/android/bin/android_run_skia View 2 chunks +10 lines, -4 lines 0 comments Download
M tools/dm_flags.json View 1 9 chunks +432 lines, -0 lines 0 comments Download
M tools/dm_flags.py View 2 chunks +27 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
msarett
Fix android_run_skia script to allow for larger blacklist
5 years, 9 months ago (2015-03-25 18:26:08 UTC) #4
djsollen
script looks good
5 years, 9 months ago (2015-03-25 18:33:49 UTC) #5
msarett
5 years, 9 months ago (2015-03-25 18:39:35 UTC) #7
scroggo
lgtm https://codereview.chromium.org/1011653004/diff/60001/tools/dm_flags.py File tools/dm_flags.py (right): https://codereview.chromium.org/1011653004/diff/60001/tools/dm_flags.py#newcode78 tools/dm_flags.py:78: # New ico files that fail on SkImageDecoder ...
5 years, 9 months ago (2015-03-25 18:51:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011653004/60001
5 years, 9 months ago (2015-03-25 19:17:34 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 19:28:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://skia.googlesource.com/skia/+/114912d4b9dec67b02223ffa57ffab686442e332

Powered by Google App Engine
This is Rietveld 408576698