Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 101163003: Move ConfigurationPolicyProvider to components/policy/. (Closed)

Created:
7 years ago by dconnelly
Modified:
7 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move ConfigurationPolicyProvider to components/policy/. This is a re-land of https://codereview.chromium.org/92153002/. BUG=271392 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238406

Patch Set 1 #

Patch Set 2 : rename target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -907 lines) Patch
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_profile_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/proxy_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/proxy_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/async_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/async_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/config_dir_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/configuration_policy_provider.h View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/policy/configuration_policy_provider.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/policy/configuration_policy_provider_test.h View 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/policy/configuration_policy_provider_test.cc View 1 chunk +0 lines, -403 lines 0 comments Download
M chrome/browser/policy/forwarding_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/forwarding_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/mock_configuration_policy_provider.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/policy/mock_configuration_policy_provider.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_loader_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_service_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/profile_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/policy_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/policy.gypi View 1 2 chunks +33 lines, -2 lines 0 comments Download
A + components/policy/core/common/configuration_policy_provider.h View 3 chunks +7 lines, -5 lines 0 comments Download
A + components/policy/core/common/configuration_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/common/configuration_policy_provider_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/configuration_policy_provider_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/policy/core/common/mock_configuration_policy_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/policy/core/common/mock_configuration_policy_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dconnelly
Trying again with a renamed test target.
7 years ago (2013-12-03 12:37:42 UTC) #1
Joao da Silva
lgtm Thanks for uploading the original first :-)
7 years ago (2013-12-03 13:17:29 UTC) #2
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-03 14:48:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/101163003/20001
7 years ago (2013-12-03 14:51:18 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-03 16:12:40 UTC) #5
Message was sent while issue was closed. 
Change committed as 238406

Powered by Google App Engine
This is Rietveld 408576698