Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1011613004: [bindings] Split toUInt64 into fast inline vs slow non-inline code paths. (Closed)

Created:
5 years, 9 months ago by vivekg_samsung
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg, Jens Widell
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Split toUInt64 into fast inline vs slow non-inline code paths. R=haraken@chromium.org, jl@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M Source/bindings/core/v8/V8Binding.h View 1 chunk +14 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 2 chunks +12 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vivekg
PTAL, thanks.
5 years, 9 months ago (2015-03-16 09:24:25 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-16 10:54:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011613004/1
5 years, 9 months ago (2015-03-16 10:55:14 UTC) #5
Jens Widell
LGTM
5 years, 9 months ago (2015-03-16 11:01:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011613004/1
5 years, 9 months ago (2015-03-16 11:02:42 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 11:03:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191905

Powered by Google App Engine
This is Rietveld 408576698